chore: better linting

Author: jef

.gitignore

@@ -1,6 +1,4 @@
 .idea/
 .vscode/
 
-build/
-coverage/
 node_modules/

.prettierignore

@@ -0,0 +1 @@
+dist

.prettierrc

@@ -0,0 +1 @@
+{}

eslint.config.mjs

@@ -1,15 +1,22 @@
-// @ts-check
-
-import eslint from "@eslint/js";
+import { defineConfig } from "eslint/config";
+import js from "@eslint/js";
+import globals from "globals";
 import tseslint from "typescript-eslint";
-import prettierConfig from "eslint-plugin-prettier/recommended";
+import eslintConfigPrettier from "eslint-config-prettier/flat";
 
-export default tseslint.config(
-  eslint.configs.recommended,
-  tseslint.configs.strict,
-  tseslint.configs.stylistic,
-  prettierConfig,
+export default defineConfig([
+  {
+    files: ["**/*.{js,mjs,cjs,ts,mts,cts}"],
+    plugins: { js },
+    extends: ["js/recommended"],
+  },
+  {
+    files: ["**/*.{js,mjs,cjs,ts,mts,cts}"],
+    languageOptions: { globals: globals.browser },
+  },
+  tseslint.configs.recommended,
+  eslintConfigPrettier,
   {
-    ignores: ["dist/**", "node_modules/**"],
+    ignores: ["dist"],
   },
-);
+]);

package-lock.json

@@ -43,7 +43,7 @@
     "@types/node": "^24.0.15",
     "eslint": "^9.31.0",
     "eslint-config-prettier": "^10.1.8",
-    "eslint-plugin-prettier": "^5.5.3",
+    "globals": "^16.3.0",
     "prettier": "^3.6.2",
     "rollup": "^4.45.1",
     "tslib": "^2.8.1",

package.json

@@ -1,6 +1,6 @@
 import {
   getConventionalCommitTypes,
-  lintPullRequest,
+  isConventionalCommitTitleValid,
   isBotIgnored,
 } from "./lint.js";
 import { context } from "@actions/github";
@@ -27,7 +27,7 @@ describe("getConvetionalCommitTypes tests", () => {
   });
 });
 
-describe("lintPullRequest tests", () => {
+describe("isConventionalCommitTitleValid tests", () => {
   const tests = [
     { args: "feat: test", expected: true },
     { args: "feat(test): test", expected: true },
@@ -42,7 +42,7 @@ describe("lintPullRequest tests", () => {
 
   tests.forEach(({ args, expected }) => {
     it(`should pass or fail linting ['${args}', '${expected}']`, async () => {
-      expect(await lintPullRequest(args)).toBe(expected);
+      expect(await isConventionalCommitTitleValid(args)).toBe(expected);
     });
   });
 
@@ -54,31 +54,43 @@ describe("lintPullRequest tests", () => {
     it("should pass if subject matches pattern", async () => {
       vi.spyOn(core, "getInput").mockReturnValue("matching");
 
-      expect(await lintPullRequest(`feat: matching`)).toBe(true);
-      expect(await lintPullRequest(`feat(test): matching`)).toBe(true);
+      expect(await isConventionalCommitTitleValid(`feat: matching`)).toBe(true);
+      expect(await isConventionalCommitTitleValid(`feat(test): matching`)).toBe(
+        true,
+      );
     });
 
     it("should fail if subject does not match pattern", async () => {
       vi.spyOn(core, "getInput").mockReturnValue("not-matching");
 
-      expect(await lintPullRequest(`feat: matching`)).toBe(false);
-      expect(await lintPullRequest(`feat(test): matching`)).toBe(false);
+      expect(await isConventionalCommitTitleValid(`feat: matching`)).toBe(
+        false,
+      );
+      expect(await isConventionalCommitTitleValid(`feat(test): matching`)).toBe(
+        false,
+      );
     });
 
     it("should handle empty subject pattern", async () => {
       vi.spyOn(core, "getInput").mockReturnValue("");
 
-      expect(await lintPullRequest("feat: test")).toBe(true);
-      expect(await lintPullRequest("feat(test): test")).toBe(true);
+      expect(await isConventionalCommitTitleValid("feat: test")).toBe(true);
+      expect(await isConventionalCommitTitleValid("feat(test): test")).toBe(
+        true,
+      );
     });
 
     it("should handle complex regex", async () => {
       vi.spyOn(core, "getInput").mockReturnValue(
         "[a-z]{1,5}[0-9]{1,3}[!@#]HELLO",
       );
 
-      expect(await lintPullRequest("feat: ab11@HELLO")).toBe(true);
-      expect(await lintPullRequest("feat(test): ddd999!HELLO")).toBe(true);
+      expect(await isConventionalCommitTitleValid("feat: ab11@HELLO")).toBe(
+        true,
+      );
+      expect(
+        await isConventionalCommitTitleValid("feat(test): ddd999!HELLO"),
+      ).toBe(true);
     });
   });
 });

src/lint.test.ts

@@ -21,24 +21,26 @@ export function getConventionalCommitTypes(): string {
     .join("\n");
 }
 
-export async function lintPullRequest(title: string) {
+export async function isConventionalCommitTitleValid(
+  title: string,
+): Promise<boolean> {
   const subjectPatternInput = getInput("subject_pattern");
   const subjectPattern = subjectPatternInput
     ? new RegExp(subjectPatternInput)
     : null;
 
-  const matches = Object.keys(types).map((type) => {
-    return new RegExp(`^${type}(\\(.+\\))?!?:.+$`);
-  });
+  const typeRegexes = Object.keys(types).map(
+    (type) => new RegExp(`^${type}(\\(.+\\))?!?:\\s?.+$`),
+  );
 
-  const matchedType = matches.find((regex) => regex.test(title));
-  if (!matchedType) return false;
+  const hasValidType = typeRegexes.some((regex) => regex.test(title));
+  if (!hasValidType) return false;
 
   if (subjectPattern) {
-    const match = title.match(/^.+?:\s*(.+)$/);
-    if (!match || !match[1]) return false;
+    const subjectMatch = title.match(/^.+?:\s*(.+)$/);
+    if (!subjectMatch || !subjectMatch[1]) return false;
 
-    const subject = match[1];
+    const subject = subjectMatch[1];
     return subjectPattern.test(subject);
   }
 
@@ -52,7 +54,7 @@ export async function lint() {
   }
 
   const pr = await getPullRequest();
-  const isPrTitleOk = await lintPullRequest(pr.title);
+  const isPrTitleOk = await isConventionalCommitTitleValid(pr.title);
 
   if (isPrTitleOk) {
     await deletePrComment();