Backups are not in the directory the documentation says they're in

[fizbin]

Description of the bug

The jellyfin documentation at https://jellyfin.org/docs/general/administration/backup-and-restore claims that for the official .deb packages backups are created at /var/lib/jellyfin/backups. In fact, backups are created at /var/lib/jellyfin/data/backups.

I do not have access to a system using the official redhat packages, but it appears that the documentation there contains a similar error.

Reproduction steps

1. Upgrade Jellyfin to 10.11.1 on a machine with a large enough disk to take backups using the official .deb images
2. Take a backup using the administrative dashboard
3. Observe on the machine that the backup is in /var/lib/jellyfin/data/backups and not where the documentation said.

What is the current bug behavior?

The documentation and where jellyfin stores backups disagree

What is the expected correct behavior?

The documentation and where jellyfin stores backups agree

Jellyfin Server version

10.10.0+

Specify commit id

No response

Specify unstable release number

No response

Specify version number

No response

Specify the build version

10.11.1

Environment

- OS: Debian
- Linux Kernel: 6.8.8-2-pve
- Virtualization: PCT (Proxmox LXC)
- Clients:
- Browser:
- FFmpeg Version:
- Playback Method:
- Hardware Acceleration:
- GPU Model:
- Plugins:
- Reverse Proxy:
- Base URL:
- Networking:
- Jellyfin Data Storage:
- Media Storage:
- External Integrations:

Jellyfin logs

Initially, I had mounted a device for extra backup space at /var/lib/jellyfin/backups as per the documentation, but couldn't take backups:

System.InvalidOperationException: The backup directory '/var/lib/jellyfin/data/backups' does not have at least '5GiB' free space. Cannot create backup.
   at Jellyfin.Server.Implementations.FullSystemBackup.BackupService.CreateBackupAsync(BackupOptionsDto backupOptions)
   at Jellyfin.Api.Controllers.BackupController.CreateBackup(BackupOptionsDto backupOptions)
   at lambda_method1100(Closure, Object)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ActionMethodExecutor.AwaitableObjectResultExecutor.Execute(ActionContext actionContext, IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeActionMethodAsync>g__Awaited|12_0(ControllerActionInvoker invoker, ValueTask`1 actionResultValueTask)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.<InvokeNextActionFilterAsync>g__Awaited|10_0(ControllerActionInvoker invoker, Task lastTask, State next, Scope scope, Object state, Boolean isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Rethrow(ActionExecutedContextSealed context)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker.InvokeInnerFilterAsync()

FFmpeg logs

Client / Browser logs

No response

Relevant screenshots or videos

No response

Additional information

No response

[joshuaboniface]

Definitely a bug/oversight in the docs. We'd welcome a PR fixing that up!

[AllegraCodes]

The built-in backup location as well as the manual backup instructions for the official docker image is also not quite right. I'm guessing it works the same on all platforms, which would mean the same fix is needed for all the platforms except Windows, but I haven't confirmed that yet and don't have access to a Mac. Correct me if I'm wrong but the server code looks like it always uses the configured jellyfin data directory, then /data/backups on all platforms. Looking specifically at BaseApplicationPaths.cs lines 36 and 82.