Incomplete instructions for stripping nginx's logs of api keys. #1638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds the more up to date
ApiKeyURL parameter to the instructions on how to set up stripping sensitive informatione from nginx's logs. I found two more possible apikey parameters in the code, but I am unsure if they need to be added as well. Maybe someone with a bit more insight can help here.Copyediting
To avoid "nitpicky" reviews, please ensure all of the following have been done for any non-trivial changes.
aspell).While you're waiting for someone to look at your pull request, How about looking at another one? You do not have to do this, but it will help ensure your PR is reviewed quickly in turn.
Issues
closes #1637