-
Notifications
You must be signed in to change notification settings - Fork 620
Fixing issue with invalid certificate test #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue with invalid certificate test #1834
Conversation
|
@krisstern as this is possibly blocking BOM release later this week. |
|
Ok so there is more to it as Windows build still has the previous message. |
|
Original test passes on Java 17 but not 21/25. |
a91199a to
fb5933f
Compare
|
Sorry for the force push, I didn't want to do yet-another-spotless-fix-commit. |
krisstern
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks so much @alecharp! |
|
@krisstern the plugin BOM test will continue to fail on this test until a new plugin release has been created that includes this fix. Are you available to create the plugin release or would you prefer that I create the plugin release? |
Testing done
The test
GitLabConnectionConfigSSLTestis failing in BOM (jenkinsci/bom#5931) but also locally on the currentmasterbranch.This is to fix it.
Submitter checklist