Add only option for postgresql add_index #2343
Merged
+26
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyevans
reviewed
Nov 7, 2025
Owner
jeremyevans
left a comment
jeremyevans
left a comment
There was a problem hiding this comment.
Thanks for the patch! In principle I'm fine with adding these changes. However, please separate the commits appropriately (one just for :only, the other just for :include_indexes), with appropriate commit messages.
Other issues: ONLY is only supported on PostgreSQL 11+, so add the appropriate spec guard. Use a separate spec for the the include_invalid change, and update the documentation for to mention include_invalid.
| # :opclass :: Set an opclass to use for all columns (per-column opclasses require | ||
| # custom SQL). | ||
| # :tablespace :: Specify tablespace for index. | ||
| # :only :: Create index only for parent table |
Owner
There was a problem hiding this comment.
Suggested change
| # :only :: Create index only for parent table | |
| # :only :: Create index only for given table, not for any child tables (PostgreSQL 11+) |
Contributor
Author
There was a problem hiding this comment.
Sure, thank you! Done.
Owner
|
Thanks for your work on this. I thought some more about the API and decided to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to create ON ONLY index for partitioned table to create then concurrently indexes on each partition and then attach partition indexes.
For that I added only option for
add_index.Also I added include_invalid for
indexes.