Skip to content

Conversation

@yuvipanda
Copy link
Collaborator

This allows users to simply share the URL again, but may cause problems with overwriting if the page is reloaded. So perhaps this needs to be optional?

Alternatively, we can make a fork specifically focused on jupyterlite only?

This allows users to simply share the URL again, but may
cause problems with overwriting if the page is reloaded. So
perhaps this needs to be optional?

Alternatively, we can make a fork specifically focused on
jupyterlite only?
@github-actions
Copy link

Binder 👈 Launch a Binder on branch yuvipanda/jupyterlab-open-url-parameter/noremove-param

@jtpio jtpio added the enhancement New feature or request label Feb 19, 2024
@jtpio
Copy link
Member

jtpio commented Feb 19, 2024

Alternatively, we can make a fork specifically focused on jupyterlite only?

Hmm this might increase maintenance effort. Otherwise we could also introduce another query parameter to check whether to remove the fromURL parameter? Or via a setting which could also be configured by users via the Setting Manager? (and via an overrides.json to enable it by default in JupyterLite)

@yuvipanda
Copy link
Collaborator Author

@jtpio I think an additional query parameter makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants