feat: expose get_satisfied_experiments and refactor code for resolution #755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
| ) -> Result<serde_json::Map<String, Value>> { | ||
| self.eval_config(evaluation_context).await | ||
| prefix_filters: Option<Vec<String>>, | ||
| ) -> Result<(serde_json::Map<String, Value>, Vec<String>)> { |
Collaborator
There was a problem hiding this comment.
Should we make a type for this?
Collaborator
Author
There was a problem hiding this comment.
Aliasing it for now
Datron
force-pushed
the
expose-satisfied-experiments
branch
2 times, most recently
from
46e7325 to
5fdfbca
Compare
- Add variants chosen to the Resolution Details so users can validate and debug
Datron
force-pushed
the
expose-satisfied-experiments
branch
from
5fdfbca to
00fb43c
Compare
mahatoankitkumar
approved these changes
Nov 28, 2025
Collaborator
mahatoankitkumar
left a comment
mahatoankitkumar
left a comment
There was a problem hiding this comment.
TODO for the next PR.
- Making a separate type instead of aliasing.
- And expose these functions in other providers too.
knutties
reviewed
Nov 28, 2025
| .await | ||
| } | ||
|
|
||
| pub async fn get_running_experiments_from_provider(&self) -> Result<Experiments> { |
Collaborator
There was a problem hiding this comment.
Why call this get_running_experiments_from_provider while using the get_cached_experiments inside? 1-1 naming will be helpful here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Internal juspay systems require more information from the provider to provide adequate debugging information
Solution
Future TODO
Have all s11n providers expose the same interface. This will be done in a future PR