Use ordinal string comparer

Author: kbilsted

StatePrinter.Tests/PerformanceTests/ManySmallCollections.cs

@@ -62,6 +62,7 @@ public void TestTheOverheadOfStartingUp()
         /// <summary>
         /// Many small objects reveals the overhead of introspecting types.
         /// 
+        /// V.3.0.0
         //1000:  Time:    159 length     123003
         //2000:  Time:     18 length     246003
         //4000:  Time:     35 length     492003
@@ -85,9 +86,15 @@ public void DumpManySmallCollections()
 
         /// <summary>
         /// Printing 1.000.000 objects.
+        /// V3.0.0
         //curly: 17906 length:  195888912
         //json:  11433 length:  123000003
         //xml:   17106 length:  232000033
+        //
+        // v3.0.1
+        //curly: 18197 length:  195888912
+        //json:  11139 length:  123000003
+        //xml:   14419 length:  232000033
         /// </summary>
         [Test]
         public void TiminAllOutputFormattersAtNElements()

StatePrinter.Tests/PerformanceTests/ManySmallObjects.cs

@@ -91,17 +91,23 @@ public void TestTheOverheadOfStartingUp()
         /// 
         /// 
         /// Version 2.2 - HPPavilion 7
-        /// 1000:  158
-        /// 2000:  8
-        /// 4000:  19
-        /// 8000:  50
         /// 16000:  86
         /// 32000:  175
         /// 64000:  371
         /// 128000:  781
         /// 256000:  1590
         /// 512000:  3217
         /// 1024000:  6265
+        /// 
+        /// 
+        /// version 3.0.1 - HPPavilion 7
+        /// 16000:        50
+        /// 32000:       112
+        /// 64000:       275
+        /// 128000:       551 
+        /// 256000:      1078 
+        /// 512000:      2010 
+        /// 1024000:      4507  
         /// </summary>
         [Test]
         public void DumpManySmallObjects()
@@ -114,9 +120,15 @@ public void DumpManySmallObjects()
 
         /// <summary>
         /// Printing 1.000.000 objects.
+        /// v2.xx
         /// curly: 6959 length:   62888908
         /// json:  6578 length:   59000006
         /// xml:   8036 length:   89000074
+        /// 
+        /// v3.0.1
+        /// curly: 6596 length:   82888914
+        /// json:  3749 length:   58000003
+        /// xml:   4859 length:   93000035
         /// </summary>
         [Test]
         public void TiminAllOutputFormattersAtNElements()

StatePrinter/FieldHarvesters/HarvestHelper.cs

@@ -92,7 +92,7 @@ public IEnumerable<MemberInfo> GetFieldsAndProperties(Type type, BindingFlags fl
         static bool NonBackingFieldFilter(MemberInfo x)
         {
             return x.MemberType == MemberTypes.Field
-              && !x.Name.EndsWith(BackingFieldSuffix);
+              && !x.Name.EndsWith(BackingFieldSuffix, StringComparison.Ordinal);
         }
 
         static bool IndexerFilter(MemberInfo x)
@@ -109,10 +109,10 @@ static bool IndexerFilter(MemberInfo x)
         public bool IsHarvestable(Type type)
         {
             var typename = type.ToString();
-            if (typename.StartsWith("System.Reflection")
-                || typename.StartsWith("System.Runtime")
-                || typename.StartsWith("System.SignatureStruct")
-                || typename.StartsWith("System.Func"))
+            if (typename.StartsWith("System.Reflection", StringComparison.Ordinal)
+                || typename.StartsWith("System.Runtime", StringComparison.Ordinal)
+                || typename.StartsWith("System.SignatureStruct", StringComparison.Ordinal)
+                || typename.StartsWith("System.Func", StringComparison.Ordinal))
                 return false;
             return true;
         }
@@ -122,7 +122,7 @@ public bool IsHarvestable(Type type)
         /// </summary>
         public string SanitizeFieldName(string fieldName)
         {
-            return fieldName.StartsWith("<")
+            return fieldName.StartsWith("<", StringComparison.Ordinal)
               ? fieldName.Substring(1).Replace(BackingFieldSuffix, "")
               : fieldName;
         }

StatePrinter/FieldHarvesters/PublicFieldsHarvester.cs

@@ -51,7 +51,7 @@ public List<SanitizedFieldInfo> GetFields(Type type)
                 fields.Where(
                     x =>
                     ((FieldInfo)x.FieldInfo).IsPublic
-                    || x.FieldInfo.Name.EndsWith(HarvestHelper.BackingFieldSuffix));
+                    || x.FieldInfo.Name.EndsWith(HarvestHelper.BackingFieldSuffix, StringComparison.Ordinal));
 
             return res.ToList();
         }

StatePrinter/OutputFormatters/JsonStyle.cs

@@ -198,15 +198,15 @@ string MakeFieldValue(Token token, string value)
             if (token.Field.Key != null)
             {
                 return IsQuoted(token.Field.Key)
-                    ? string.Format("{0}: {1}", token.Field.Key, value)
-                    : string.Format("\"{0}\": {1}", token.Field.Key, value);
+                    ? string.Concat(token.Field.Key, ": ", value)
+                    : string.Concat("\"", token.Field.Key, "\": ", value);
             }
 
             // Field.Name is empty if the ROOT-element-name has not been supplied.
             if (string.IsNullOrEmpty(token.Field.Name))
                 return value;
 
-            return string.Format("\"{0}\": {1}", token.Field.Name, value);
+            return string.Concat("\"", token.Field.Name, "\": ", value);
         }
 
         /// <summary>
@@ -234,7 +234,7 @@ string OptionalComma(List<Token> tokens, int position)
 
         bool IsQuoted(string s)
         {
-            return s.Length >= 2 && s.StartsWith("\"") && s.EndsWith("\"");
+            return s.Length >= 2 && s.StartsWith("\"", StringComparison.Ordinal) && s.EndsWith("\"", StringComparison.Ordinal);
         }
     }
 }

StatePrinter/OutputFormatters/XmlStyle.cs

@@ -141,7 +141,7 @@ private string TagName(Token token, out string keyAttr)
 
         private string Unquote(string s)
         {
-            return s.Length >= 2 && s.StartsWith("\"") && s.EndsWith("\"")
+            return s.Length >= 2 && s.StartsWith("\"", StringComparison.Ordinal) && s.EndsWith("\"", StringComparison.Ordinal)
                 ? s.Substring(1, s.Length - 2) : s;
         }
     }

StatePrinter/StatePrinter.csproj

@@ -36,7 +36,7 @@
     <DefineConstants>TRACE</DefineConstants>
     <ErrorReport>prompt</ErrorReport>
     <WarningLevel>4</WarningLevel>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
   <PropertyGroup>
     <ApplicationIcon>gfx\stateprinter.ico</ApplicationIcon>

StatePrinter/TestAssistance/EnvironmentReader.cs

@@ -30,7 +30,7 @@ public bool UseTestAutoRewrite()
             string result = Environment.GetEnvironmentVariable(
                 Usetestautorewrite, 
                 EnvironmentVariableTarget.User);
-            return "true".Equals(result);
+            return "true".Equals(result, StringComparison.Ordinal);
         }
     }
 }