Move default database config setup to DatabaseTest

Author: victorsfleite

tests/Checks/BasePreflightCheck.php

@@ -3,7 +3,6 @@
 namespace Kirschbaum\PreflightChecks\Tests\Checks;
 
 use Orchestra\Testbench\TestCase;
-use Illuminate\Contracts\Config\Repository;
 use Kirschbaum\PreflightChecks\Checks\Result;
 use Kirschbaum\PreflightChecks\Checks\PreflightCheck;
 use Kirschbaum\PreflightChecks\PreflightChecksServiceProvider;
@@ -18,24 +17,6 @@ abstract class BasePreflightCheck extends TestCase
      */
     protected $preflightCheckClass;
 
-    /**
-     * Define environment setup.
-     *
-     * @param  \Illuminate\Foundation\Application  $app
-     * @return void
-     */
-    protected function defineEnvironment($app)
-    {
-        // Setup default database to use sqlite :memory:
-        tap($app['config'], function (Repository $config) {
-            $config->set('database.connections.test_default', [
-                'driver'   => 'sqlite',
-                'database' => ':memory:',
-                'prefix'   => '',
-            ]);
-        });
-    }
-
     public function checkConfigValues(PreflightCheck $preflightCheck)
     {
         $config = $this->getProtectedProperty($preflightCheck, 'requiredConfig');

tests/Checks/DatabaseTest.php

@@ -22,6 +22,13 @@ protected function setUp(): void
         parent::setUp();
 
         config(['database.default' => static::TEST_DEFAULT_DB_CONNECTION]);
+        config([
+            'database.connections.' . static::TEST_DEFAULT_DB_CONNECTION => [
+                'driver' => 'sqlite',
+                'database' => ':memory:',
+                'prefix' => '',
+            ],
+        ]);
     }
 
     /**
@@ -68,7 +75,7 @@ public static function providesDatabaseScenarios()
         ];
 
         yield 'Default checks default' => [
-            ['connection' => static::TEST_DEFAULT_DB_CONNECTION, 'driver' => 'sqlite', 'database' => ':memory:'],
+            ['connection' => static::TEST_DEFAULT_DB_CONNECTION],
             static::TEST_DEFAULT_DB_CONNECTION,
         ];