Skip to content

Conversation

@benoit-pierre
Copy link
Member

@benoit-pierre benoit-pierre commented Nov 16, 2025

To work around MuPDF' slow server:

  • increase connection timeout and maximum allowed total time
  • drop curl builtin retries: we already manually retrying 2 times anyway (in case of possible incorrect checksum)

This change is Reviewable

To work around MuPDF' slow server:
- increase connection timeout and maximum allowed total time
- drop curl builtin retries: we already manually retrying 2 times anyway
  (in case of possible incorrect checksum)
@Frenzie
Copy link
Member

Frenzie commented Nov 16, 2025

Wasn't there some fallback mechanism?
https://github.com/ArtifexSoftware/mupdf-downloads/releases

@benoit-pierre
Copy link
Member Author

Wasn't there some fallback mechanism? https://github.com/ArtifexSoftware/mupdf-downloads/releases

Nope! I missed that (I follow https://github.com/ArtifexSoftware/mupdf/releases.atom in my RSS reader, which only has the automatically generated source artifacts, sans sub-modules).

@Frenzie
Copy link
Member

Frenzie commented Nov 16, 2025

Close this one with #2218 in place?

@benoit-pierre
Copy link
Member Author

I don't know, I think it still make sense if a mirror is particularly slow. Plus there's no need for retrying within individual curl calls if we do retry ourselves anyway (and potentially alternate with a fallback).

@benoit-pierre
Copy link
Member Author

The increased timeout might make things a little slower… ¯\(ツ)

@Frenzie
Copy link
Member

Frenzie commented Nov 16, 2025

10 already seems quite long is the main thing I was referring to. There's no need to curl retry.

@benoit-pierre
Copy link
Member Author

I can't currently download from https://casper.mupdf.com/downloads/archive/mupdf-1.26.11-source.tar.lz with a connect timeout of 10, it takes 14 seconds for the connection to be established… (Plus max-time at 30s was also to slow, but my current connection is also not particularly fast).

@Frenzie
Copy link
Member

Frenzie commented Nov 16, 2025

I'm surprised it would start at 14 if it didn't at 10, but I can confirm that it currently starts after some 13-14 seconds. (It does seem to finish nearly instantaneously for me.)

@Frenzie Frenzie merged commit b4f8938 into koreader:master Nov 16, 2025
3 checks passed
@benoit-pierre benoit-pierre deleted the pr/tweak_download_curl_cmdline branch November 16, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants