-
Notifications
You must be signed in to change notification settings - Fork 124
cmake: tweak download command line #2217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: tweak download command line #2217
Conversation
To work around MuPDF' slow server: - increase connection timeout and maximum allowed total time - drop curl builtin retries: we already manually retrying 2 times anyway (in case of possible incorrect checksum)
|
Wasn't there some fallback mechanism? |
Nope! I missed that (I follow https://github.com/ArtifexSoftware/mupdf/releases.atom in my RSS reader, which only has the automatically generated source artifacts, sans sub-modules). |
|
Close this one with #2218 in place? |
|
I don't know, I think it still make sense if a mirror is particularly slow. Plus there's no need for retrying within individual curl calls if we do retry ourselves anyway (and potentially alternate with a fallback). |
|
The increased timeout might make things a little slower… ¯\(ツ)/¯ |
|
10 already seems quite long is the main thing I was referring to. There's no need to curl retry. |
|
I can't currently download from https://casper.mupdf.com/downloads/archive/mupdf-1.26.11-source.tar.lz with a connect timeout of 10, it takes 14 seconds for the connection to be established… (Plus max-time at 30s was also to slow, but my current connection is also not particularly fast). |
|
I'm surprised it would start at 14 if it didn't at 10, but I can confirm that it currently starts after some 13-14 seconds. (It does seem to finish nearly instantaneously for me.) |
To work around MuPDF' slow server:
This change is