Make constraint queries schema-aware for multi-tenancy

Prior to this change, the ConstraintQueries class queried
pg_catalog.pg_constraint without filtering by PostgreSQL schema.
This caused incorrect behavior in multi-tenant environments using
django-tenants, where each tenant has its own schema. The queries
would detect constraints from other tenants' schemas, leading to
false positives (e.g., ConstraintAlreadyExists errors when creating
a second tenant).

This change adds INNER JOINs with pg_catalog.pg_class and
pg_catalog.pg_namespace to filter constraints by current_schema().
This ensures that constraint checks only look at the current tenant's
schema, not across all schemas in the database.

Affected queries:
- CHECK_EXISTING_CONSTRAINT
- CHECK_CONSTRAINT_IS_VALID
- CHECK_CONSTRAINT_IS_NOT_VALID

Related issue: #92

Author: RJPercival

src/django_pg_migration_tools/operations.py

@@ -53,25 +53,34 @@ class IndexQueries:
 
 class ConstraintQueries:
     CHECK_EXISTING_CONSTRAINT = dedent("""
-        SELECT conname
-        FROM pg_catalog.pg_constraint
-        WHERE conname = {constraint_name};
+        SELECT con.conname
+        FROM pg_catalog.pg_constraint con
+        INNER JOIN pg_catalog.pg_class rel ON rel.oid = con.conrelid
+        INNER JOIN pg_catalog.pg_namespace nsp ON nsp.oid = rel.relnamespace
+        WHERE con.conname = {constraint_name}
+            AND nsp.nspname = current_schema();
     """)
 
     CHECK_CONSTRAINT_IS_VALID = dedent("""
         SELECT 1
-        FROM pg_catalog.pg_constraint
+        FROM pg_catalog.pg_constraint con
+        INNER JOIN pg_catalog.pg_class rel ON rel.oid = con.conrelid
+        INNER JOIN pg_catalog.pg_namespace nsp ON nsp.oid = rel.relnamespace
         WHERE
-            conname = {constraint_name}
-            AND convalidated IS TRUE;
+            con.conname = {constraint_name}
+            AND con.convalidated IS TRUE
+            AND nsp.nspname = current_schema();
     """)
 
     CHECK_CONSTRAINT_IS_NOT_VALID = dedent("""
         SELECT 1
-        FROM pg_catalog.pg_constraint
+        FROM pg_catalog.pg_constraint con
+        INNER JOIN pg_catalog.pg_class rel ON rel.oid = con.conrelid
+        INNER JOIN pg_catalog.pg_namespace nsp ON nsp.oid = rel.relnamespace
         WHERE
-            conname = {constraint_name}
-            AND convalidated IS FALSE;
+            con.conname = {constraint_name}
+            AND con.convalidated IS FALSE
+            AND nsp.nspname = current_schema();
     """)
 
     ALTER_TABLE_CONSTRAINT_NOT_NULL_NOT_VALID = dedent("""

tests/django_pg_migration_tools/test_multitenancy.py

@@ -60,9 +60,6 @@ def setup_schemas(self):
             cursor.execute("DROP SCHEMA IF EXISTS tenant1 CASCADE")
             cursor.execute("DROP SCHEMA IF EXISTS tenant2 CASCADE")
 
-    @pytest.mark.xfail(
-        reason="Constraint queries not yet schema-aware", raises=AssertionError
-    )
     def test_check_existing_constraint_only_sees_current_schema(self):
         """
         Test that CHECK_EXISTING_CONSTRAINT only detects constraints in the
@@ -99,9 +96,6 @@ def test_check_existing_constraint_only_sees_current_schema(self):
                 "Constraint should NOT be visible in tenant2"
             )
 
-    @pytest.mark.xfail(
-        reason="Constraint queries not yet schema-aware", raises=AssertionError
-    )
     def test_check_constraint_is_valid_only_sees_current_schema(self):
         """
         Test that CHECK_CONSTRAINT_IS_VALID only detects valid constraints
@@ -140,9 +134,6 @@ def test_check_constraint_is_valid_only_sees_current_schema(self):
                 "Valid constraint should NOT be visible in tenant2"
             )
 
-    @pytest.mark.xfail(
-        reason="Constraint queries not yet schema-aware", raises=AssertionError
-    )
     def test_check_constraint_is_not_valid_only_sees_current_schema(self):
         """
         Test that CHECK_CONSTRAINT_IS_NOT_VALID only detects NOT VALID
@@ -190,10 +181,6 @@ def test_check_constraint_is_not_valid_only_sees_current_schema(self):
                 "NOT VALID constraint should NOT be visible in tenant2"
             )
 
-    @pytest.mark.xfail(
-        reason="Constraint queries not yet schema-aware",
-        raises=operations.ConstraintAlreadyExists,
-    )
     def test_unique_constraint_creation_in_second_schema(self):
         """
         Test that SaferAddUniqueConstraint can create a constraint in a second
@@ -286,9 +273,6 @@ def test_unique_constraint_creation_in_second_schema(self):
             # Reset to public schema
             cursor.execute("SET search_path TO public")
 
-    @pytest.mark.xfail(
-        reason="Constraint queries not yet schema-aware", raises=AssertionError
-    )
     def test_check_constraint_creation_in_second_schema(self):
         """
         Test that SaferAddCheckConstraint can create a constraint in a second