fix: avoid character positioning to break starting from alpha feature

kristos80 · kristos80 · commit 38f265fd9477 · 2025-04-17T14:08:41.000+03:00
diff --git a/src/PasswordGenerator.php b/src/PasswordGenerator.php
@@ -84,6 +84,8 @@ public function generate(PasswordGeneratorConfig $generatorConfig): string {
 
 		shuffle($password);
 
+		$password = $this->avoidConsecutiveCharacters($password);
+
 		if($generatorConfig->getAlwaysStartWithCharacter() &&
 			($lowerCount > 0 || $upperCount > 0)) {
 			foreach($password as $index => $char) {
@@ -104,8 +106,6 @@ public function generate(PasswordGeneratorConfig $generatorConfig): string {
 			}
 		}
 
-		$password = $this->avoidConsecutiveCharacters($password);
-
 		return implode("", $password);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,8 @@ public function generate(PasswordGeneratorConfig $generatorConfig): string {`
`84`	`84`
`85`	`85`	`shuffle($password);`
`86`	`86`
	`87`	`+ $password = $this->avoidConsecutiveCharacters($password);`
	`88`	`+`
`87`	`89`	`if($generatorConfig->getAlwaysStartWithCharacter() &&`
`88`	`90`	`($lowerCount > 0 \|\| $upperCount > 0)) {`
`89`	`91`	`foreach($password as $index => $char) {`
`@@ -104,8 +106,6 @@ public function generate(PasswordGeneratorConfig $generatorConfig): string {`
`104`	`106`	`}`
`105`	`107`	`}`
`106`	`108`
`107`		`- $password = $this->avoidConsecutiveCharacters($password);`
`108`		`-`
`109`	`109`	`return implode("", $password);`
`110`	`110`	`}`
`111`	`111`