Skip to content

CI is substituting the generated manifests #161

@kimwnasptd

Description

@kimwnasptd

This came up from #160 (comment)

Our CI should only be changing the image that is used by a manifest file, with the locally built one. But, right now, the deploy_component.sh is also substituting other fields instead of just the image

| sed 's/$(podDefaultsServiceName)/poddefaults-webhook-service/g' \
| sed 's/$(podDefaultsNamespace)/kubeflow/g' \
| sed "s|\$(CD_NAMESPACE)|${CD_NAMESPACE:-kubeflow}|g" \
| sed "s|\$(CD_CLUSTER_DOMAIN)|${CD_CLUSTER_DOMAIN:-cluster.local}|g" \
| sed "s|CD_NAMESPACE_PLACEHOLDER|${CD_NAMESPACE_PLACEHOLDER:-kubeflow}|g" \
| sed "s|CD_CLUSTER_DOMAIN_PLACEHOLDER|${CD_CLUSTER_DOMAIN_PLACEHOLDER:-cluster.local}|g" \

This can lead to masking errors, as we saw in #160 (comment), in which the manifests had a bug yet our CI never caught this.

cc @juliusvonkohout @kunal-511

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions