Skip to content

Conversation

@HumairAK
Copy link
Contributor

@HumairAK HumairAK commented Nov 4, 2025

No description provided.

Signed-off-by: Humair Khan <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine to move forward with this change since @chensun confirmed that @james-jwu is no longer involved in KFP.
/assign @johnugeorge @terrytangyuan @juliusvonkohout @franciscojavierarceo for review

kfp-tekton: write
pipelines: write
kfp-tekton: admin
pipelines: admin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumairAK
Copy link
Contributor Author

HumairAK commented Nov 4, 2025

cc @chensun can you confirm this is the case? I know you said James Liu had left the project, though I can't recall if you stated the same for James Wu

@juliusvonkohout juliusvonkohout self-requested a review November 5, 2025 12:35
Copy link
Member

@juliusvonkohout juliusvonkohout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the write vs administrator topic? Should we in general make maintainers administrators? That means they can bypass security checks etc. @kubeflow/kubeflow-steering-committee. Probably we need a vote on this first since it is a major governance and security change.

@juliusvonkohout
Copy link
Member

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants