Skip to content

Conversation

@nabuskey
Copy link
Collaborator

πŸ”„ Pull Request

πŸ“ Description

Brief description of changes and motivation.

🎯 Type of Change

  • πŸ› Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to change)
  • πŸ“– Documentation update
  • πŸ§ͺ Test improvement
  • πŸ”§ Refactoring (no functional changes)

πŸ§ͺ Testing

  • βœ… All existing tests pass (task test)
  • πŸ”¬ Tested with MCP Inspector
  • πŸ“Š Tested with sample Spark data
  • πŸš€ Tested with real Spark History Server (if applicable)

πŸ”¬ Test Commands Run

# Example:
# task test
# npx @modelcontextprotocol/inspector uv run -m spark_history_mcp.core.main

πŸ› οΈ New Tools Added (if applicable)

  • Tool Name: new_tool_name
  • Purpose: What it does
  • Usage: Example parameters

πŸ“Έ Screenshots (if applicable)

βœ… Checklist

  • πŸ” Code follows project style guidelines
  • πŸ§ͺ Added tests for new functionality
  • πŸ“– Updated documentation (README, TESTING.md, etc.)
  • πŸ”§ Pre-commit hooks pass
  • πŸ“ Added entry to CHANGELOG.md (if significant change)

πŸ“š Related Issues

Fixes #(issue number)
Related to #(issue number)

πŸ€” Additional Context


πŸŽ‰ Thank you for contributing! Your effort helps make Spark monitoring more intelligent.

Signed-off-by: Manabu McCloskey <[email protected]>
@google-oss-prow google-oss-prow bot requested a review from vara-bonthu October 24, 2025 15:49
@nabuskey nabuskey linked an issue Oct 24, 2025 that may be closed by this pull request
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 781d744 into kubeflow:main Oct 24, 2025
6 checks passed
@nabuskey nabuskey deleted the security-naming branch October 24, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SECURITY.md isn't filled in

2 participants