Skip to content

Conversation

@peschmae
Copy link
Contributor

What this PR does / why we need it:
The snapshot list, currently only shows the cluster ID this snapshot belongs to. The user is more accustomed to the cluster name, which also what he selects when creating the snapshot.

This PR adds the cluster name to a few places:

  1. Snapshot list
  2. Snapshot details
  3. Automatic backups details

Which issue(s) this PR fixes:

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Add cluster name to snapshot list and details

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2025
@kubermatic-bot
Copy link
Contributor

Hi @peschmae. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 13, 2025
@peschmae peschmae force-pushed the feat/snapshot-cluster-name branch from 08faffe to 20a1999 Compare November 13, 2025 12:49
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 13, 2025
@ahmadhamzh
Copy link
Contributor

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 17, 2025
Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback
you also need to add the cluster name on the automatic-list and the restore list

@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2025
@KhizerRehan KhizerRehan requested a review from Copilot November 20, 2025 09:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the backup-related views by displaying cluster names alongside cluster IDs, improving user experience by showing familiar cluster names instead of just technical IDs.

Key Changes:

  • Added cluster name columns to snapshot, restore, and automatic backup list views
  • Implemented cluster name lookup functionality using ClusterService
  • Enhanced detail views for snapshots and automatic backups to display cluster names

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
modules/web/src/app/backup/list/snapshot/template.html Added cluster name column to snapshot list table
modules/web/src/app/backup/list/snapshot/component.ts Implemented cluster fetching and name lookup for snapshots
modules/web/src/app/backup/list/restore/template.html Added cluster name column to restore list table
modules/web/src/app/backup/list/restore/component.ts Implemented cluster fetching and name lookup for restores
modules/web/src/app/backup/list/automatic-backup/template.html Added cluster name column to automatic backup list table
modules/web/src/app/backup/list/automatic-backup/component.ts Implemented cluster fetching and name lookup for automatic backups
modules/web/src/app/backup/details/snapshot/template.html Added cluster name property to snapshot details view
modules/web/src/app/backup/details/snapshot/component.ts Implemented cluster fetching for snapshot details
modules/web/src/app/backup/details/automatic-backup/template.html Added cluster name property to automatic backup details view
modules/web/src/app/backup/details/automatic-backup/component.ts Implemented cluster fetching for automatic backup details

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@peschmae peschmae force-pushed the feat/snapshot-cluster-name branch 3 times, most recently from 22145aa to 388192d Compare November 23, 2025 15:50
@peschmae
Copy link
Contributor Author

implemented feedback, and made sure npm run fix was run :)

Rebased also to the lastest changes on main.

Copilot finished reviewing on behalf of peschmae November 24, 2025 10:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…on forkJoins instead

Signed-off-by: Mathias Petermann <[email protected]>
@peschmae peschmae force-pushed the feat/snapshot-cluster-name branch from 388192d to 19d6542 Compare November 25, 2025 08:40
@peschmae
Copy link
Contributor Author

Implemented the recommendation by copilot review, but did not add a check if backup is undefined, as there is generally no error handling if a backup/snapshot detail page is opened with an invalid ID in the URL.

@peschmae peschmae requested a review from ahmadhamzh November 25, 2025 08:41
Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last small comment

Copy link
Contributor

@ahmadhamzh ahmadhamzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84d01a21f4a9649eb84296d925716375c4272859

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmadhamzh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@kubermatic-bot kubermatic-bot merged commit cedce4b into kubermatic:main Nov 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants