Skip to content

Commit 5605f50

Browse files
committed
add more details to the proposed changes
1 parent 8529ad1 commit 5605f50

File tree

1 file changed

+5
-5
lines changed
  • vertical-pod-autoscaler/enhancements/7571-support-pod-level-resources

1 file changed

+5
-5
lines changed

vertical-pod-autoscaler/enhancements/7571-support-pod-level-resources/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ Add two new recommender flags to cap Pod-level recommendations:
279279
- `--pod-recommendation-max-allowed-cpu`: Sets the global maximum CPU the recommender may recommend at Pod scope.
280280
- `--pod-recommendation-max-allowed-memory`: Sets the global maximum memory the recommender may recommend at Pod scope.
281281

282-
Per-container recommendations must be adjusted so that their total does not exceed these global constraints, using the same enforcement formula described in the `minAllowed` and `maxAllowed` sections. The VerticalPodAutoscaler maximum (`spec.resourcePolicy.maxAllowed`) take precedence over these global Pod maximums when both are present.
282+
Per-container recommendations must be adjusted so that their total does not exceed these global constraints, using the same enforcement formula described in the `minAllowed` and `maxAllowed` sections. The VerticalPodAutoscaler maximum (Pod-level or container-level `maxAllowed`) takes precedence over these global Pod maximums when both are present.
283283

284284
#### Recommender
285285

@@ -406,11 +406,11 @@ If Pod-level limits are omitted, the new Pod-level limits cannot be determined.
406406

407407
### Pod-level Policies
408408

409-
If the Pod-level policies (i.e. `pod.minAllowed` and `pod.maxAllowed`) are violated, the recommender and the admission controller should proportionally adjust the Pod-level recommendations:
410-
* If the Pod-level recommendation is less than `pod.minAllowed`, use the minAllowed value as the new Pod-level recommendation.
411-
* If the Pod-level recommendation is greater than `pod.maxAllowed`, use the maxAllowed value as the new Pod-level recommendation.
409+
If the Pod-level policies (i.e. `podPolicies.minAllowed` and `podPolicies.maxAllowed`) are violated, the recommender and the admission controller should proportionally adjust the Pod-level recommendations:
410+
* If the Pod-level recommendation is less than `podPolicies.minAllowed`, use the minAllowed value as the new Pod-level recommendation.
411+
* If the Pod-level recommendation is greater than `podPolicies.maxAllowed`, use the maxAllowed value as the new Pod-level recommendation.
412412

413-
The updater skips Pods for which no Pod-level recommendations exist in the corresponding VPA object. Consequently the updater may skip validating `pod.minAllowed` and `pod.maxAllowed` for such Pods.
413+
The updater skips Pods for which no Pod-level recommendations exist in the corresponding VPA object. Consequently the updater may skip validating `podPolicies.minAllowed` and `podPolicies.maxAllowed` for such Pods.
414414

415415
### LimitRange object
416416

0 commit comments

Comments
 (0)