Skip to content

Commit a6f1d0b

Browse files
committed
add more details to the proposed changes
1 parent a93ac77 commit a6f1d0b

File tree

1 file changed

+9
-9
lines changed
  • vertical-pod-autoscaler/enhancements/7571-support-pod-level-resources

1 file changed

+9
-9
lines changed

vertical-pod-autoscaler/enhancements/7571-support-pod-level-resources/README.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,11 @@ With this option, VPA computes and applies only pod-level recommendations.
209209
The following terms and definitions are used throughout this AEP:
210210

211211
* **Pods with Pod-level resources** - The user defines a resources stanza at the Pod level and may optionally define container-level resources for some containers. The VPA manages only the Pod-level resources stanza, and container-level resources only for containers that were initially defined within the workload API.
212-
* **Pods with Container-level resources** The user defines resources stanzas within individual containers. The VPA manages only container-level resources, and by default manages all containers in this type of Pod.
213-
* **Pods without any resources stanza** These Pods are treated as Pod-level by default, and the VPA manages the Pod-level resources stanza. In this AEP, the term "Pods with Pod-level resources" also includes "Pods without any resources stanza".
214-
* **Pod LimitRange object** Refers to a `LimitRange` object with `type=Pod`.
215-
* **Container LimitRange object** Refers to a `LimitRange` object with `type=Container`.
216-
* **Latest VPA version** In this AEP, the term "latest VPA version" refers to version 1.6.0.
212+
* **Pods with Container-level resources** - The user defines resources stanzas within individual containers. The VPA manages only container-level resources, and by default manages all containers in this type of Pod.
213+
* **Pods without any resources stanza** - These Pods are treated as Pod-level by default, and the VPA manages the Pod-level resources stanza. In this AEP, the term "Pods with Pod-level resources" also includes "Pods without any resources stanza".
214+
* **Pod LimitRange object** - Refers to a `LimitRange` object with `type=Pod`.
215+
* **Container LimitRange object** - Refers to a `LimitRange` object with `type=Container`.
216+
* **Latest VPA version** - In this AEP, the term "latest VPA version" refers to version 1.6.0.
217217

218218
### Proposal
219219

@@ -342,10 +342,10 @@ Table Legend:
342342
| 10 | CR | unset | unset | CMAX | unset | CMAX if CR > CMAX `[c]` |
343343
| 11 | CR | unset | CMIN | unset | unset | CMIN if CR < CMIN `[c]` |
344344

345-
* Annotation [a] In this case the admission controller cannot determine a recommendation for the container. As a result the container is excluded from the Pod-level recommendation calculation.
346-
* Annotation [b] For container-level resources, when a request is not specified but a limit is set, Kubernetes defaults the request to equal the limit (see [upstream defaulting behavior](https://github.com/kubernetes/kubernetes/blob/005f184ab631e52195ed6d129969ff3914d51c98/pkg/apis/core/v1/defaults.go#L167-L228)). This AEP proposes that such limits should be considered when calculating Pod-level recommendations.
347-
* Annotation [c] This AEP proposes updating the admission controller to ensure that the conditions referenced by this annotation are enforced.
348-
* Annotation [d] The container's target value from the VPA object takes precedence over any container-level requests specified in the workload API.
345+
* Annotation `[a]` - In this case the admission controller cannot determine a recommendation for the container. As a result the container is excluded from the Pod-level recommendation calculation.
346+
* Annotation `[b]` - For container-level resources, when a request is not specified but a limit is set, Kubernetes defaults the request to equal the limit (see [upstream defaulting behavior](https://github.com/kubernetes/kubernetes/blob/005f184ab631e52195ed6d129969ff3914d51c98/pkg/apis/core/v1/defaults.go#L167-L228)). This AEP proposes that such limits should be considered when calculating Pod-level recommendations.
347+
* Annotation `[c]` - This AEP proposes updating the admission controller to ensure that the conditions referenced by this annotation are enforced.
348+
* Annotation `[d]` - The container's target value from the VPA object takes precedence over any container-level requests specified in the workload API.
349349

350350
2. Calculate the Pod-level recommendation using the values from the recommendation column in the previous table, separately for CPU and memory. For example, the CPU calculation can be expressed as:
351351

0 commit comments

Comments
 (0)