Missing linebreak when providing etcd extraargs

[everflux]

What Happened?

When starting minikube in this setting

minikube start --cpus 6 --memory 8192 --ports 80:80,443:443,5000:5000 \
--extra-config=scheduler.bind-address=0.0.0.0 \
--extra-config=controller-manager.bind-address=0.0.0.0 \
--extra-config=etcd.listen-metrics-urls='http://0.0.0.0:2381'

the generated clusterconfig is invalid as linebreak is missing for the etcd extraArgs, preventing minikube from starting

apiVersion: kubeadm.k8s.io/v1beta4
kind: ClusterConfiguration
apiServer:
  certSANs: ["127.0.0.1", "localhost", "192.168.49.2"]
  extraArgs:
    - name: "enable-admission-plugins"
      value: "NamespaceLifecycle,LimitRanger,ServiceAccount,DefaultStorageClass,DefaultTolerationSeconds,NodeRestriction,MutatingAdmissionWebhook,ValidatingAdmissionWebhook,ResourceQuota"
controllerManager:
  extraArgs:
    - name: "allocate-node-cidrs"
      value: "true"
    - name: "bind-address"
      value: "0.0.0.0"
    - name: "leader-elect"
      value: "false"
scheduler:
  extraArgs:
    - name: "bind-address"
      value: "0.0.0.0"
    - name: "leader-elect"
      value: "false"
certificatesDir: /var/lib/minikube/certs
clusterName: mk
controlPlaneEndpoint: control-plane.minikube.internal:8443
etcd:
  local:
    dataDir: /var/lib/minikube/etcd    extraArgs:
      - name: "listen-metrics-urls"
        value: "http://0.0.0.0:2381"
kubernetesVersion: v1.34.0
networking:
  dnsDomain: cluster.local
  podSubnet: "10.244.0.0/16"
  serviceSubnet: 10.96.0.0/12

Attach the log file

log.txt

Operating System

Ubuntu

Driver

Docker

[divysinghvi]

Minikube’s startup fails because its automatically generated cluster configuration becomes invalid when we use the etcd --extra-config flag. The fix is to either quote that flag properly, or avoid having Minikube generate it altogether by supplying our own clean YAML config i thing this could help you the most not causing the linebreak issue

[everflux]

I did try several quoting options neither worked.
Do you have an example? Thanks !

[medyagh]

@everflux i am curious does this basic example work from the website https://minikube.sigs.k8s.io/docs/handbook/config/

minikube start --extra-config=apiserver.v=10 --extra-config=kubelet.max-pods=100

asking just to verify if basic example works and it only fails with more than 1 extra-arg?

[everflux]

This works:
minikube start --extra-config=apiserver.v=10 --extra-config=kubelet.max-pods=100

This does not:
minikube start --extra-config=etcd.listen-metrics-urls="http://0.0.0.0:2381"

The generated YAML is not valid, due to a missing linebreak before 'extraArgs'

...
etcd:
  local:
    dataDir: /var/lib/minikube/etcd    extraArgs:  <<<<
      - name: "listen-metrics-urls"    ^^^^^^^^^^^ 
        value: "http://0.0.0.0:2381"
...