Skip to content

Conversation

@minikube-bot
Copy link
Collaborator

Kubernetes Project just updated the golang version, updating minikube golang to match Kubernetes.

This PR was auto-generated by make update-golang-version using update-golang-version.yml CI Workflow.

@minikube-bot
Copy link
Collaborator Author

ok-to-build-image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 10, 2025
@k8s-ci-robot k8s-ci-robot requested review from medyagh and nirs November 10, 2025 22:43
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: minikube-bot
Once this PR has been reviewed and has the lgtm label, please assign comradeprogrammer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @minikube-bot. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2025
@medyagh
Copy link
Member

medyagh commented Nov 11, 2025

15:10:46  * [new branch]            yearly-leaderboard-f58582b -> minikube-bot/yearly-leaderboard-f58582b
15:10:46  * [new branch]            yearly-leaderboard-f6964fc -> minikube-bot/yearly-leaderboard-f6964fc
15:10:46  * [new branch]            yearly-leaderboard-f881b33 -> minikube-bot/yearly-leaderboard-f881b33
15:10:46 + git checkout -b minikube-bot-auto_bump_golang_version-3cda61b minikube-bot/auto_bump_golang_version-3cda61b
15:10:46 Previous HEAD position was eca7daad9a Merge ed753e6bc16861f3271f9c3a88bd97cfe5f32ccc into 02ccb7ce963e56f8ee24db3728c585a76faef3b6
15:10:46 Switched to a new branch 'minikube-bot-auto_bump_golang_version-3cda61b'
15:10:46 Branch 'minikube-bot-auto_bump_golang_version-3cda61b' set up to track remote branch 'auto_bump_golang_version-3cda61b' from 'minikube-bot'.
15:10:46 + sed -i 's|Version = .*|Version = "v0.0.48-1762815147-21884"|;s|baseImageSHA = .*|baseImageSHA = "912a31c941b02838c93bfa14c26a58336244d6ac65d6eed21bcee158527c272f"|;s|gcrRepo = .*|gcrRepo = "gcr.io/k8s-minikube/kicbase-builds"|;s|dockerhubRepo = .*|dockerhubRepo = "docker.io/kicbase/build"|' pkg/drivers/kic/types.go
15:10:46 + make generate-docs
15:10:46 go run cmd/extract/extract.go
15:10:47 Compiling translation strings...
15:10:47 Writing to de.json (1011 translated, 63 untranslated)
15:10:47 Writing to el.json (670 translated, 404 untranslated)
15:10:47 Writing to es.json (219 translated, 855 untranslated)
15:10:47 Writing to fr.json (1069 translated, 5 untranslated)
15:10:47 Writing to id.json (1011 translated, 63 untranslated)
15:10:47 Writing to ja.json (939 translated, 135 untranslated)
Writing to ko.json (321 translated, 753 untranslated)
Writing to pl.json (205 translated, 869 untranslated)
Writing to ru.json (23 translated, 1051 untranslated)
Writing to uk.json (1056 translated, 18 untranslated)
Writing to zh-CN.json (1011 translated, 63 untranslated)
Done!
go build  -tags "libvirt_dlopen" -ldflags="-X k8s.io/minikube/pkg/version.version=v1.37.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.37.0-1762018871-21834 -X k8s.io/minikube/pkg/version.gitCommitID="ed753e6bc16861f3271f9c3a88bd97cfe5f32ccc-dirty" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v5" -o out/minikube k8s.io/minikube/cmd/minikube
out/minikube generate-docs --path ./site/content/en/docs/commands/ --test-path ./site/content/en/docs/contrib/tests.en.md --code-path ./site/content/en/docs/contrib/errorcodes.en.md
* Docs have been saved at - ./site/content/en/docs/commands/
* Test docs have been saved at - ./site/content/en/docs/contrib/tests.en.md
* Error code docs have been saved at - ./site/content/en/docs/contrib/errorcodes.en.md
+ generate_package_list
+ make
make: 'out/minikube' is up to date.
+ ./out/minikube delete
! "minikube" profile does not exist, trying anyways.
* Removed all traces of the "minikube" cluster.
+ ./out/minikube start
* minikube v1.37.0 on Debian 11.11 (amd64)
* Automatically selected the docker driver
* Using Docker driver with root privileges
* Starting "minikube" primary control-plane node in "minikube" cluster
* Pulling base image v0.0.48-1762815147-21884 ...
* Downloading Kubernetes v1.34.1 preload ...

X Exiting due to RUNTIME_ENABLE: Failed to enable container runtime: sudo systemctl restart cri-docker.socket: Process exited with status 1
stdout:

stderr:
Failed to restart cri-docker.socket: Unit cri-docker.socket has a bad unit file setting.
See system logs and 'systemctl status cri-docker.socket' for details.

sudo journalctl --no-pager -u cri-docker.socket:
-- stdout --
Nov 10 23:10:46 minikube systemd[1]: /lib/systemd/system/cri-docker.socket:1: Assignment outside of section. Ignoring.
Nov 10 23:10:46 minikube systemd[1]: cri-docker.socket: Unit has no Listen setting (ListenStream=, ListenDatagram=, ListenFIFO=, ...). Refusing.
Nov 10 23:10:46 minikube systemd[1]: /lib/systemd/system/cri-docker.socket:1: Assignment outside of section. Ignoring.
Nov 10 23:10:46 minikube systemd[1]: cri-docker.socket: Unit has no Listen setting (ListenStream=, ListenDatagram=, ListenFIFO=, ...). Refusing.
Nov 10 23:10:46 minikube systemd[1]: /lib/systemd/system/cri-docker.socket:1: Assignment outside of section. Ignoring.
Nov 10 23:10:46 minikube systemd[1]: /lib/systemd/system/cri-docker.socket:1: Assignment outside of section. Ignoring.
Nov 10 23:10:46 minikube systemd[1]: /lib/systemd/system/cri-docker.socket:1: Assignment outside of section. Ignoring.
Nov 10 23:10:46 minikube systemd[1]: cri-docker.socket: Unit has no Listen setting (ListenStream=, ListenDatagram=, ListenFIFO=, ...). Refusing.

-- /stdout --
* 
╭─────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                             │
│    * If the above advice does not help, please let us know:                                 │
│      https://github.com/kubernetes/minikube/issues/new/choose                               │
│                                                                                             │
│    * Please run `minikube logs --file=logs.txt` and attach logs.txt to the GitHub issue.    │
│                                                                                             │
╰─────────────────────────────────────────────────────────────────────────────────────────────╯

Build step 'Execute shell' marked build as failure
[Google Cloud Storage Plugin] Uploading: kic_image_build.txt
Adding one-line test results to commit status...
Setting status of ed753e6bc16861f3271f9c3a88bd97cfe5f32ccc to FA

@prezha
Copy link
Contributor

prezha commented Nov 11, 2025

as bumping go usually requires bumping golangci-lint as well (or latter might complain about being compiled with an older version of go than the one code, that it is supposed to run linters against, is using), i added a commit that bumps golangci-lint to v2.1.6, and also silenced some revive linter complaints, as i think those should be addressed in a separate pr

the other commit was to address next complaint the 'Verify go mod tidy' step had


local minikube binary building & testing

kvm driver

$ minikube start
😄  minikube v1.37.0 on Opensuse-Tumbleweed 20251110
✨  Automatically selected the kvm2 driver. Other choices: qemu2, podman, virtualbox, ssh
👍  Starting "minikube" primary control-plane node in "minikube" cluster
💾  Downloading Kubernetes v1.34.1 preload ...
    > preloaded-images-k8s-v18-v1...:  337.01 MiB / 337.01 MiB  100.00% 10.92 M
🔥  Creating kvm2 VM (CPUs=2, Memory=6144MB, Disk=20000MB) ...
🐳  Preparing Kubernetes v1.34.1 on Docker 28.5.1 ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
$ kubectl get pods -A
NAMESPACE     NAME                               READY   STATUS    RESTARTS     AGE
kube-system   coredns-66bc5c9577-55nkh           1/1     Running   0            37s
kube-system   etcd-minikube                      1/1     Running   0            43s
kube-system   kube-apiserver-minikube            1/1     Running   0            46s
kube-system   kube-controller-manager-minikube   1/1     Running   0            43s
kube-system   kube-proxy-lh9rk                   1/1     Running   0            38s
kube-system   kube-scheduler-minikube            1/1     Running   0            43s
kube-system   storage-provisioner                1/1     Running   1 (6s ago)   42s

docker driver

$ minikube start
😄  minikube v1.37.0 on Opensuse-Tumbleweed 20251110
✨  Automatically selected the docker driver. Other choices: kvm2, qemu2, podman, virtualbox, ssh
📌  Using Docker driver with root privileges
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🚜  Pulling base image v0.0.48-1761985721-21837 ...
    > gcr.io/k8s-minikube/kicbase...:  500.36 MiB / 500.36 MiB  100.00% 7.49 Mi
🔥  Creating docker container (CPUs=2, Memory=16000MB) ...
🐳  Preparing Kubernetes v1.34.1 on Docker 28.5.1 ...
🔗  Configuring bridge CNI (Container Networking Interface) ...
🔎  Verifying Kubernetes components...
    ▪ Using image gcr.io/k8s-minikube/storage-provisioner:v5
🌟  Enabled addons: storage-provisioner, default-storageclass
🏄  Done! kubectl is now configured to use "minikube" cluster and "default" namespace by default
kubectl get pods -A
NAMESPACE     NAME                               READY   STATUS    RESTARTS      AGE
kube-system   coredns-66bc5c9577-92dgv           1/1     Running   0             90s
kube-system   etcd-minikube                      1/1     Running   0             97s
kube-system   kube-apiserver-minikube            1/1     Running   0             96s
kube-system   kube-controller-manager-minikube   1/1     Running   0             96s
kube-system   kube-proxy-rhdmv                   1/1     Running   0             91s
kube-system   kube-scheduler-minikube            1/1     Running   0             96s
kube-system   storage-provisioner                1/1     Running   1 (59s ago)   94s

@prezha
Copy link
Contributor

prezha commented Nov 11, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2025
@k8s-ci-robot
Copy link
Contributor

@minikube-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integration-kvm-containerd-linux-x86-64 797899c link true /test integration-kvm-containerd-linux-x86-64
integration-docker-crio-linux-x86-64 797899c link true /test integration-docker-crio-linux-x86-64
integration-kvm-crio-linux-x86-64 797899c link true /test integration-kvm-crio-linux-x86-64
integration-docker-containerd-linux-x86-64 797899c link true /test integration-docker-containerd-linux-x86-64
integration-none-docker-linux-x86-64 797899c link true /test integration-none-docker-linux-x86-64
integration-kvm-docker-linux-x86-64 797899c link true /test integration-kvm-docker-linux-x86-64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@medyagh
Copy link
Member

medyagh commented Nov 12, 2025

thank you @prezha lets see if the image builds now

@medyagh
Copy link
Member

medyagh commented Nov 12, 2025

ok-to-build-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants