CI: make "bump all ISO/image workflow" configurable #20760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
size/S
medyagh
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
prezha
reviewed
May 15, 2025
Contributor
prezha
left a comment
prezha
left a comment
There was a problem hiding this comment.
pls check if the commented change was intentional
| required: true | ||
| # Uncomment after crictl/cri-o issue resolved: https://github.com/kubernetes/minikube/issues/18359 | ||
| # default: "update-buildkit-version,update-cni-plugins-version,update-containerd-version,update-cri-o-version,update-crictl-version,update-crun-version,update-docker-version,update-docker-buildx-version,update-golang-version,update-nerdctl-version,update-nerdctld-version,update-runc-version,update-ubuntu-version" | ||
| default: "update-buildkit-version,update-cni-plugins-version,update-crun-version,update-docker-version,update-docker-buildx-version,update-golang-version,update-runc-version,update-ubuntu-version" |
Contributor
There was a problem hiding this comment.
update-docker-buildx-version was disabled before - are we re-enabling it here intentionally?
here's an overview:
old new
--- ---
update-buildkit-version update-buildkit-version
update-cni-plugins-version update-cni-plugins-version
# update-containerd-version <
# update-cri-o-version <
# update-crictl-version <
update-crun-version update-crun-version
# update-docker-buildx-version > update-docker-buildx-version
update-docker-version update-docker-version
update-golang-version update-golang-version
# update-nerdctl-version <
# update-nerdctld-version <
update-runc-version update-runc-version
update-ubuntu-version update-ubuntu-version
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
prezha
approved these changes
May 15, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh, prezha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example Run here https://github.com/medyagh/minikube/actions/runs/15032565584