Merge pull request #205 from flavio/ci-test-all-features

flavio · web-flow · commit 46777c74824e · 2025-11-10T11:11:31.000+01:00
ci test all features
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -37,6 +37,8 @@ jobs:
         run: cargo test
       - name: test with default features disabled
         run: cargo test --no-default-features
+      - name: test with all features enabled
+        run: cargo test --all-features
 
   fmt:
     name: Rustfmt
diff --git a/Cargo.toml b/Cargo.toml
@@ -7,7 +7,7 @@ authors = [
 ]
 description = "Kubewarden Policy SDK for the Rust language"
 documentation = "https://docs.rs/kubewarden-policy-sdk"
-edition = "2021"
+edition = "2024"
 license = "Apache-2.0"
 name = "kubewarden-policy-sdk"
 repository = "https://github.com/kubewarden/policy-sdk-rust"
diff --git a/src/crd/policies/admission_policy.rs b/src/crd/policies/admission_policy.rs
@@ -6,8 +6,8 @@ use k8s_openapi::{
 };
 
 use crate::crd::policies::common::{
-    default_policy_server, default_settings, BackgroundAudit, FailurePolicy, MatchPolicy,
-    PolicyMode, SideEffects, TimeoutSeconds,
+    BackgroundAudit, FailurePolicy, MatchPolicy, PolicyMode, SideEffects, TimeoutSeconds,
+    default_policy_server, default_settings,
 };
 
 #[derive(
@@ -259,8 +259,9 @@ spec:
 "#;
 
         let err = serde_yaml::from_str::<AdmissionPolicy>(yaml).unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("unknown field `contextAwareResources`"));
+        assert!(
+            err.to_string()
+                .contains("unknown field `contextAwareResources`")
+        );
     }
 }
diff --git a/src/crd/policies/admission_policy_group.rs b/src/crd/policies/admission_policy_group.rs
@@ -8,8 +8,8 @@ use k8s_openapi::{
 };
 
 use crate::crd::policies::common::{
-    default_policy_server, default_settings, BackgroundAudit, FailurePolicy, MatchPolicy,
-    PolicyMode, SideEffects, TimeoutSeconds,
+    BackgroundAudit, FailurePolicy, MatchPolicy, PolicyMode, SideEffects, TimeoutSeconds,
+    default_policy_server, default_settings,
 };
 
 #[derive(
@@ -238,6 +238,7 @@ spec:
                         }
                     ]
                 })),
+                ..Default::default()
             },
         );
         policies.insert(
@@ -253,6 +254,7 @@ spec:
                         }
                     ]
                 })),
+                ..Default::default()
             },
         );
         policies.insert(
@@ -264,6 +266,7 @@ spec:
                         "reject": ["latest"]
                     }
                 })),
+                ..Default::default()
             },
         );
 
@@ -277,20 +280,23 @@ spec:
             PolicyGroupMember {
                 module: "ghcr.io/kubewarden/policies/verify-image-signatures:v0.3.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
+                ..Default::default()
             },
         );
         policies.insert(
             "signed_by_bob".to_string(),
             PolicyGroupMember {
                 module: "ghcr.io/kubewarden/policies/verify-image-signatures:v0.3.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
+                ..Default::default()
             },
         );
         policies.insert(
             "reject_latest".to_string(),
             PolicyGroupMember {
                 module: "registry://ghcr.io/kubewarden/policies/trusted-repos:v0.2.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
+                ..Default::default()
             },
         );
 
@@ -349,9 +355,10 @@ spec:
 "#;
 
         let err = serde_yaml::from_str::<AdmissionPolicyGroup>(yaml).unwrap_err();
-        assert!(err
-            .to_string()
-            .contains("unknown field `namespaceSelector`"),);
+        assert!(
+            err.to_string()
+                .contains("unknown field `namespaceSelector`"),
+        );
     }
 
     #[test]
diff --git a/src/crd/policies/cluster_admission_policy.rs b/src/crd/policies/cluster_admission_policy.rs
@@ -6,8 +6,8 @@ use k8s_openapi::{
 };
 
 use crate::crd::policies::common::{
-    default_policy_server, default_settings, BackgroundAudit, ContextAwareResource, FailurePolicy,
-    MatchPolicy, PolicyMode, SideEffects, TimeoutSeconds,
+    BackgroundAudit, ContextAwareResource, FailurePolicy, MatchPolicy, PolicyMode, SideEffects,
+    TimeoutSeconds, default_policy_server, default_settings,
 };
 
 #[derive(
diff --git a/src/crd/policies/cluster_admission_policy_group.rs b/src/crd/policies/cluster_admission_policy_group.rs
@@ -8,8 +8,8 @@ use k8s_openapi::{
 };
 
 use crate::crd::policies::common::{
-    default_policy_server, default_settings, BackgroundAudit, ContextAwareResource, FailurePolicy,
-    MatchPolicy, PolicyMode, SideEffects, TimeoutSeconds,
+    BackgroundAudit, ContextAwareResource, FailurePolicy, MatchPolicy, PolicyMode, SideEffects,
+    TimeoutSeconds, default_policy_server, default_settings,
 };
 
 #[derive(
@@ -258,6 +258,7 @@ spec:
                     ]
                 })),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
         policies.insert(
@@ -274,6 +275,7 @@ spec:
                     ]
                 })),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
         policies.insert(
@@ -286,6 +288,7 @@ spec:
                     }
                 })),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
 
@@ -300,6 +303,7 @@ spec:
                 module: "ghcr.io/kubewarden/policies/verify-image-signatures:v0.3.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
         policies.insert(
@@ -308,6 +312,7 @@ spec:
                 module: "ghcr.io/kubewarden/policies/verify-image-signatures:v0.3.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
         policies.insert(
@@ -316,6 +321,7 @@ spec:
                 module: "registry://ghcr.io/kubewarden/policies/trusted-repos:v0.2.0".to_string(),
                 settings: RawExtension(serde_json::json!({})),
                 context_aware_resources: vec![],
+                ..Default::default()
             },
         );
 
diff --git a/src/host_capabilities/crypto.rs b/src/host_capabilities/crypto.rs
@@ -1,6 +1,6 @@
 use std::fmt;
 
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use serde::{Deserialize, Serialize};
 
 use crate::host_capabilities::crypto_v1::{
diff --git a/src/host_capabilities/kubernetes.rs b/src/host_capabilities/kubernetes.rs
@@ -1,4 +1,4 @@
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use k8s_openapi::api::authorization::v1::{SubjectAccessReviewSpec, SubjectAccessReviewStatus};
 use serde::{Deserialize, Serialize};
 
diff --git a/src/host_capabilities/mod.rs b/src/host_capabilities/mod.rs
@@ -141,13 +141,8 @@ pub mod crypto_v1 {
         where
             D: Deserializer<'de>,
         {
-            Ok(Option::<String>::deserialize(deserializer)?.and_then(|s| {
-                if s.is_empty() {
-                    None
-                } else {
-                    Some(s)
-                }
-            }))
+            Ok(Option::<String>::deserialize(deserializer)?
+                .and_then(|s| if s.is_empty() { None } else { Some(s) }))
         }
 
         pub fn serialize<S>(
diff --git a/src/host_capabilities/net.rs b/src/host_capabilities/net.rs
@@ -1,4 +1,4 @@
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use serde::{Deserialize, Serialize};
 use serde_json::json;
 
diff --git a/src/host_capabilities/oci.rs b/src/host_capabilities/oci.rs
@@ -1,4 +1,4 @@
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use oci_spec::image::{ImageConfiguration, ImageIndex, ImageManifest};
 use serde::{Deserialize, Serialize};
 use serde_json::json;
diff --git a/src/host_capabilities/verification.rs b/src/host_capabilities/verification.rs
@@ -1,5 +1,5 @@
 use crate::host_capabilities::SigstoreVerificationInputV2;
-use anyhow::{anyhow, Result};
+use anyhow::{Result, anyhow};
 use serde::{Deserialize, Serialize};
 use std::collections::BTreeMap;
 #[cfg(test)]
diff --git a/src/lib.rs b/src/lib.rs
@@ -237,7 +237,7 @@ where
 /// use guest::prelude::*;
 /// use kubewarden_policy_sdk::protocol_version_guest;
 ///
-/// #[no_mangle]
+/// #[unsafe(no_mangle)]
 /// pub extern "C" fn wapc_init() {
 ///     register_function("protocol_version", protocol_version_guest);
 ///     // register other waPC functions
diff --git a/src/logging/event.rs b/src/logging/event.rs
@@ -1,5 +1,5 @@
 use anyhow::Result;
-use slog::{OwnedKVList, KV};
+use slog::{KV, OwnedKVList};
 
 use super::ser::KubewardenLogSerializer;
 use serde_json::json;
diff --git a/src/logging/ser.rs b/src/logging/ser.rs
@@ -79,7 +79,7 @@ impl slog::Serializer for KubewardenFieldSerializer<'_> {
 #[cfg(test)]
 mod test {
     use super::*;
-    use slog::{o, Record, KV};
+    use slog::{KV, Record, o};
 
     fn do_serializer<S: slog::Serializer>(serializer: &mut S) {
         // rinfo_static and the values passed to Record::new are irrelevant for this test and
diff --git a/src/non_wasm.rs b/src/non_wasm.rs
@@ -3,10 +3,10 @@
 // be linked. This allows to run targets such as `cargo test` on host
 // targets.
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __console_log(_ptr: *const u8, _len: usize) {}
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 #[allow(clippy::too_many_arguments)]
 pub fn __host_call(
     _bd_ptr: *const u8,
@@ -21,27 +21,27 @@ pub fn __host_call(
     0
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __host_response(_ptr: *mut u8) {}
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __host_response_len() -> usize {
     0
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __host_error_len() -> usize {
     0
 }
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __host_error(_ptr: *mut u8) {}
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __guest_response(_ptr: *const u8, _len: usize) {}
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __guest_error(_ptr: *const u8, _len: usize) {}
 
-#[no_mangle]
+#[unsafe(no_mangle)]
 pub fn __guest_request(_op_ptr: *mut u8, _ptr: *mut u8) {}
diff --git a/src/request.rs b/src/request.rs
@@ -1,5 +1,5 @@
 use anyhow::anyhow;
-use serde::{de::DeserializeOwned, Deserialize, Serialize};
+use serde::{Deserialize, Serialize, de::DeserializeOwned};
 use std::collections::{HashMap, HashSet};
 
 cfg_if::cfg_if! {
@@ -173,38 +173,46 @@ where
             Deployment::KIND => {
                 let deployment = serde_json::from_value::<Deployment>(self.request.object.clone())?;
                 Ok(deployment.spec.and_then(|spec| spec.template.spec))
-            },
+            }
             ReplicaSet::KIND => {
                 let replicaset = serde_json::from_value::<ReplicaSet>(self.request.object.clone())?;
-                Ok(replicaset.spec.and_then(|spec| spec.template.and_then(|template| template.spec)))
-            },
+                Ok(replicaset
+                    .spec
+                    .and_then(|spec| spec.template.and_then(|template| template.spec)))
+            }
             StatefulSet::KIND => {
-                let statefulset = serde_json::from_value::<StatefulSet>(self.request.object.clone())?;
+                let statefulset =
+                    serde_json::from_value::<StatefulSet>(self.request.object.clone())?;
                 Ok(statefulset.spec.and_then(|spec| spec.template.spec))
-            },
+            }
             DaemonSet::KIND => {
                 let daemonset = serde_json::from_value::<DaemonSet>(self.request.object.clone())?;
                 Ok(daemonset.spec.and_then(|spec| spec.template.spec))
-            },
+            }
             ReplicationController::KIND => {
-                let replication_controller = serde_json::from_value::<ReplicationController>(self.request.object.clone())?;
-                Ok(replication_controller.spec.and_then(|spec| spec.template.and_then(|template| template.spec)))
-            },
+                let replication_controller =
+                    serde_json::from_value::<ReplicationController>(self.request.object.clone())?;
+                Ok(replication_controller
+                    .spec
+                    .and_then(|spec| spec.template.and_then(|template| template.spec)))
+            }
             CronJob::KIND => {
                 let cronjob = serde_json::from_value::<CronJob>(self.request.object.clone())?;
-                Ok(cronjob.spec.and_then(|spec| spec.job_template.spec.and_then(|spec| spec.template.spec)))
-            },
+                Ok(cronjob
+                    .spec
+                    .and_then(|spec| spec.job_template.spec.and_then(|spec| spec.template.spec)))
+            }
             Job::KIND => {
                 let job = serde_json::from_value::<Job>(self.request.object.clone())?;
                 Ok(job.spec.and_then(|spec| spec.template.spec))
-            },
+            }
             Pod::KIND => {
                 let pod = serde_json::from_value::<Pod>(self.request.object.clone())?;
                 Ok(pod.spec)
-            },
-            _ => {
-                Err(anyhow!("Object should be one of these kinds: Deployment, ReplicaSet, StatefulSet, DaemonSet, ReplicationController, Job, CronJob, Pod"))
             }
+            _ => Err(anyhow!(
+                "Object should be one of these kinds: Deployment, ReplicaSet, StatefulSet, DaemonSet, ReplicationController, Job, CronJob, Pod"
+            )),
         }
     }
 }
diff --git a/src/test.rs b/src/test.rs
@@ -1,5 +1,5 @@
 use crate::response::ValidationResponse;
-use serde::{de::DeserializeOwned, Serialize};
+use serde::{Serialize, de::DeserializeOwned};
 use serde_json::json;
 use std::fs::File;
 use std::io::BufReader;

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ authors = [`
`7`	`7`	`]`
`8`	`8`	`description = "Kubewarden Policy SDK for the Rust language"`
`9`	`9`	`documentation = "https://docs.rs/kubewarden-policy-sdk"`
`10`		`-edition = "2021"`
	`10`	`+edition = "2024"`
`11`	`11`	`license = "Apache-2.0"`
`12`	`12`	`name = "kubewarden-policy-sdk"`
`13`	`13`	`repository = "https://github.com/kubewarden/policy-sdk-rust"`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-use anyhow::{anyhow, Result};`
	`1`	`+use anyhow::{Result, anyhow};`
`2`	`2`	`use k8s_openapi::api::authorization::v1::{SubjectAccessReviewSpec, SubjectAccessReviewStatus};`
`3`	`3`	`use serde::{Deserialize, Serialize};`
`4`	`4`