chore: address PR feedback

Author: seaofawareness

libs/langgraph-checkpoint-aws/langgraph_checkpoint_aws/store/valkey/search_strategies.py

@@ -154,11 +154,31 @@ def _execute_vector_search(self, op: SearchOp) -> list[SearchItem]:
                 )
 
             # Generate embedding for the query
+            # Try sync method first, fall back to async only if no event loop exists
             if hasattr(self.store.embeddings, "embed_query"):
                 query_vector = self.store.embeddings.embed_query(op.query)
+            elif hasattr(self.store.embeddings, "aembed_query"):
+                # Check if we're in an async context
+                try:
+                    asyncio.get_running_loop()
+                    # We're in an async context - cannot use asyncio.run()
+                    raise SearchIndexError(
+                        "Cannot generate embeddings: sync method not available "
+                        "and already in async context. Use AsyncValkeyStore instead.",
+                        index_name=index_name,
+                        index_operation="embedding_generation",
+                    )
+                except RuntimeError:
+                    # No running event loop, safe to create one
+                    query_vector = asyncio.run(
+                        self.store.embeddings.aembed_query(op.query)
+                    )
             else:
-                # Fallback to async if only async method available
-                query_vector = asyncio.run(self.store.embeddings.aembed_query(op.query))
+                raise SearchIndexError(
+                    "No embedding method available (embed_query or aembed_query)",
+                    index_name=index_name,
+                    index_operation="embedding_generation",
+                )
 
             # Pack vector to binary bytes for FT.SEARCH
             vec_bytes = struct.pack(f"{len(query_vector)}f", *query_vector)

libs/langgraph-checkpoint-aws/tests/unit_tests/store/valkey/test_valkey_index_config_unit.py

@@ -25,6 +25,25 @@ def fake_valkey_client():
     return fakeredis.FakeStrictRedis(decode_responses=False)
 
 
+def convert_hash_fields_to_str(hash_fields: dict) -> dict:
+    """Helper to convert hash field bytes to strings for test assertions.
+
+    Args:
+        hash_fields: Raw hash fields from Valkey (may contain bytes)
+
+    Returns:
+        Dictionary with bytes converted to strings (except binary vector field)
+    """
+    result = {}
+    for k, v in hash_fields.items():
+        key_str = k.decode("utf-8") if isinstance(k, bytes) else k
+        # Skip binary vector field - it's not UTF-8 text
+        if key_str == "vector" and isinstance(v, bytes):
+            result[key_str] = v  # Keep as bytes
+        else:
+            result[key_str] = v.decode("utf-8") if isinstance(v, bytes) else v
+    return result
+
 class TestValkeyIndexConfig:
     """Test suite for ValkeyIndexConfig TypedDict."""
 
@@ -682,16 +701,7 @@ def test_document_creation_includes_searchable_fields(self, fake_valkey_client):
         hash_fields = fake_valkey_client.hgetall(key)
 
         # Convert bytes keys/values to strings for easier checking
-        hash_fields_str = {}
-        for k, v in hash_fields.items():
-            key_str = k.decode("utf-8") if isinstance(k, bytes) else k
-            # Skip binary vector field - it's not UTF-8 text
-            if key_str == "vector" and isinstance(v, bytes):
-                val_str = v  # Keep as bytes
-            else:
-                val_str = v.decode("utf-8") if isinstance(v, bytes) else v
-            hash_fields_str[key_str] = val_str
-
+        hash_fields_str = convert_hash_fields_to_str(hash_fields)
         # Verify that searchable fields are included in hash fields
         # (without value_ prefix)
         assert "user_id" in hash_fields_str
@@ -744,16 +754,7 @@ def test_list_fields_handled_correctly(self, fake_valkey_client):
         hash_fields = fake_valkey_client.hgetall(key)
 
         # Convert bytes keys/values to strings for easier checking
-        hash_fields_str = {}
-        for k, v in hash_fields.items():
-            key_str = k.decode("utf-8") if isinstance(k, bytes) else k
-            # Skip binary vector field - it's not UTF-8 text
-            if key_str == "vector" and isinstance(v, bytes):
-                val_str = v  # Keep as bytes
-            else:
-                val_str = v.decode("utf-8") if isinstance(v, bytes) else v
-            hash_fields_str[key_str] = val_str
-
+        hash_fields_str = convert_hash_fields_to_str(hash_fields)
         # Verify that list fields are converted to comma-separated strings
         assert hash_fields_str["tags"] == "machine-learning,ai,python"
         assert hash_fields_str["categories"] == "tech,tutorial"