Skip to content

Conversation

@kim-em
Copy link
Contributor

@kim-em kim-em commented Nov 22, 2025

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

PR summary b3cf7a02d3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Nov 22, 2025
@b-mehta
Copy link
Contributor

b-mehta commented Nov 23, 2025

!bench

@leanprover-radar
Copy link

leanprover-radar commented Nov 23, 2025

Benchmark results for 4da9018 against b3cf7a0 are in! @b-mehta

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 4da9018.
There were no significant changes against commit b3cf7a0.

@github-actions
Copy link

File Instructions %
build +14.916⬝10⁹ (+0.00%)
Mathlib.Algebra.Module.Submodule.Equiv +1.145⬝10⁹ (+4.67%)
CI run Lakeprof report

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want this, but I'd like a second opinion.

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by j-loreaux.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the maintainer-merge A reviewer has approved the changed; awaiting maintainer approval. label Nov 26, 2025
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 26, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: allow grind to unfold abs [Merged by Bors] - feat: allow grind to unfold abs Nov 26, 2025
@mathlib-bors mathlib-bors bot closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants