Add Context() method to network.Conn #3416
Open
+295
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3116
Summary
Implements
Context()method fornetwork.Connthat returns a context cancelled when the connection closes, enabling proper resource cleanup and early cancellation of dependent work.Changes
Context()method tonetwork.Conninterfaceswarm.Connwith lifecycle-aware cancellationContext()method to mock connections for testingBenefits
.Context()fornetwork.Conn(or maybe justswarm.Conn) #3116)Testing
✅ All tests pass
✅ No regressions
✅ Build succeeds
Prior Art
Follows patterns from Go stdlib (
*http.Request.Context(),*tls.ClientHelloInfo.Context()) and quic-go (quic.Connection.Context())