cmake: disable ARM64 ASM on Windows #1211
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vszakats
changed the title
ARM64 ASM on Windows generates a lot of `-Wasm-operand-widths` compiler warnings. It also seems to break bignum calculations, resulting in: ``` curl: (35) TLS connect error: error:04FFF077:rsa routines:CRYPTO_internal:wrong signature length ``` and other issues. This option did not cause an issue with MSVC ARM64. The reason for this is that the only ASM code for ARM64 is the bignum implementation (crypto/bn/arch/aarch64) and that ASM code is guarded for `__GNUC__`, meaning gcc and llvm/clang, and never MSVC or clang-cl. Follow-up to 1df6b52 libressl#1177 Fixes libressl#1210
Contributor
Author
You're very welcome. Yes, that matches my impression. (Amended the patch to avoid checking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM64 ASM on Windows generates a lot of
-Wasm-operand-widthscompilerwarnings (with llvm/clang). It also seems to break bignum calculations,
resulting in:
and other issues.
This option did not cause an issue with MSVC ARM64. The reason for this
is that the only ASM code for ARM64 is the bignum implementation
(crypto/bn/arch/aarch64) and that ASM code is guarded for
__GNUC__,meaning gcc and llvm/clang, and never MSVC or clang-cl.
Follow-up to 1df6b52 #1177
Fixes #1210