Skip to content

Commit 2f848a0

Browse files
build(deps): bump the opentelemetry group with 2 updates (#3607)
* build(deps): bump the opentelemetry group with 2 updates Bumps the opentelemetry group with 2 updates: [opentelemetry](https://github.com/open-telemetry/opentelemetry-rust) and [opentelemetry_sdk](https://github.com/open-telemetry/opentelemetry-rust). Updates `opentelemetry` from 0.27.1 to 0.28.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry-0.27.1...opentelemetry-0.28.0) Updates `opentelemetry_sdk` from 0.27.1 to 0.28.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-rust/releases) - [Commits](open-telemetry/opentelemetry-rust@opentelemetry_sdk-0.27.1...opentelemetry_sdk-0.28.0) --- updated-dependencies: - dependency-name: opentelemetry dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry - dependency-name: opentelemetry_sdk dependency-type: direct:production update-type: version-update:semver-minor dependency-group: opentelemetry ... Signed-off-by: dependabot[bot] <[email protected]> * fix(deps): Fix build breakages from opentelemetry-sdk 0.28 The changes here are fairly small, with the main two being a change to an import path and replacing a privated `new` function with a builder. Signed-off-by: Scott Fleener <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Scott Fleener <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Scott Fleener <[email protected]>
1 parent faa42fd commit 2f848a0

File tree

5 files changed

+47
-33
lines changed

5 files changed

+47
-33
lines changed

Cargo.lock

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1273,7 +1273,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
12731273
checksum = "fc2f4eb4bc735547cfed7c0a4922cbd04a4655978c09b54f1f7b228750664c34"
12741274
dependencies = [
12751275
"cfg-if",
1276-
"windows-targets 0.48.5",
1276+
"windows-targets 0.52.0",
12771277
]
12781278

12791279
[[package]]
@@ -2983,15 +2983,15 @@ dependencies = [
29832983

29842984
[[package]]
29852985
name = "opentelemetry"
2986-
version = "0.27.1"
2986+
version = "0.28.0"
29872987
source = "registry+https://github.com/rust-lang/crates.io-index"
2988-
checksum = "ab70038c28ed37b97d8ed414b6429d343a8bbf44c9f79ec854f3a643029ba6d7"
2988+
checksum = "236e667b670a5cdf90c258f5a55794ec5ac5027e960c224bff8367a59e1e6426"
29892989
dependencies = [
29902990
"futures-core",
29912991
"futures-sink",
29922992
"js-sys",
29932993
"pin-project-lite",
2994-
"thiserror 1.0.69",
2994+
"thiserror 2.0.11",
29952995
"tracing",
29962996
]
29972997

@@ -3008,17 +3008,17 @@ dependencies = [
30083008

30093009
[[package]]
30103010
name = "opentelemetry_sdk"
3011-
version = "0.27.1"
3011+
version = "0.28.0"
30123012
source = "registry+https://github.com/rust-lang/crates.io-index"
3013-
checksum = "231e9d6ceef9b0b2546ddf52335785ce41252bc7474ee8ba05bfad277be13ab8"
3013+
checksum = "84dfad6042089c7fc1f6118b7040dc2eb4ab520abbf410b79dc481032af39570"
30143014
dependencies = [
30153015
"futures-channel",
30163016
"futures-executor",
30173017
"futures-util",
30183018
"opentelemetry",
30193019
"percent-encoding",
30203020
"rand 0.8.5",
3021-
"thiserror 1.0.69",
3021+
"thiserror 2.0.11",
30223022
]
30233023

30243024
[[package]]

linkerd/opentelemetry/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ http-body = { workspace = true }
1313
linkerd-error = { path = "../error" }
1414
linkerd-metrics = { path = "../metrics" }
1515
linkerd-trace-context = { path = "../trace-context" }
16-
opentelemetry = { version = "0.27", default-features = false, features = ["trace"] }
17-
opentelemetry_sdk = { version = "0.27", default-features = false, features = ["trace"] }
16+
opentelemetry = { version = "0.28", default-features = false, features = ["trace"] }
17+
opentelemetry_sdk = { version = "0.28", default-features = false, features = ["trace"] }
1818
opentelemetry-proto = { path = "../../opentelemetry-proto" }
1919
tonic = { workspace = true, default-features = false, features = [
2020
"prost",

linkerd/opentelemetry/src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ use opentelemetry_proto::{
2424
transform::{common::ResourceAttributesWithSchema, trace::group_spans_by_resource_and_scope},
2525
};
2626
pub use opentelemetry_sdk as sdk;
27-
pub use opentelemetry_sdk::export::trace::SpanData;
27+
pub use opentelemetry_sdk::trace::SpanData;
2828
use opentelemetry_sdk::trace::SpanLinks;
2929
use tokio::{sync::mpsc, time};
3030
use tonic::{self as grpc, body::BoxBody, client::GrpcService};

opentelemetry-proto/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@ Vendored from https://github.com/open-telemetry/opentelemetry-rust/.
1414
[dependencies]
1515
tonic = { workspace = true, features = ["codegen", "prost", "transport"] }
1616
prost = { workspace = true }
17-
opentelemetry = { version = "0.27", default-features = false, features = ["trace"] }
18-
opentelemetry_sdk = { version = "0.27", default-features = false, features = ["trace"] }
17+
opentelemetry = { version = "0.28", default-features = false, features = ["trace"] }
18+
opentelemetry_sdk = { version = "0.28", default-features = false, features = ["trace"] }
1919

2020
[dev-dependencies]
21-
opentelemetry = { version = "0.27", default-features = false, features = ["trace", "testing"] }
21+
opentelemetry = { version = "0.28", default-features = false, features = ["trace", "testing"] }
2222
tonic-build = { workspace = true, default-features = false, features = ["prost"] }
2323

2424
[lib]

opentelemetry-proto/src/transform/trace.rs

Lines changed: 34 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
1-
use crate::proto::resource::v1::Resource;
2-
use crate::proto::trace::v1::{span, status, ResourceSpans, ScopeSpans, Span, Status};
3-
use crate::transform::common::{to_nanos, Attributes, ResourceAttributesWithSchema};
4-
use opentelemetry::trace;
5-
use opentelemetry::trace::{Link, SpanId, SpanKind};
6-
use opentelemetry_sdk::export::trace::SpanData;
1+
use crate::{
2+
proto::{
3+
resource::v1::Resource,
4+
trace::v1::{span, status, ResourceSpans, ScopeSpans, Span, Status},
5+
},
6+
transform::common::{to_nanos, Attributes, ResourceAttributesWithSchema},
7+
};
8+
use opentelemetry::{
9+
trace,
10+
trace::{Link, SpanId, SpanKind},
11+
};
12+
use opentelemetry_sdk::trace::SpanData;
713
use std::collections::HashMap;
814

915
impl From<SpanKind> for span::SpanKind {
@@ -40,8 +46,8 @@ impl From<Link> for span::Link {
4046
}
4147
}
4248
}
43-
impl From<opentelemetry_sdk::export::trace::SpanData> for Span {
44-
fn from(source_span: opentelemetry_sdk::export::trace::SpanData) -> Self {
49+
impl From<opentelemetry_sdk::trace::SpanData> for Span {
50+
fn from(source_span: opentelemetry_sdk::trace::SpanData) -> Self {
4551
let span_kind: span::SpanKind = source_span.span_kind.into();
4652
Span {
4753
trace_id: source_span.span_context.trace_id().to_bytes().to_vec(),
@@ -185,17 +191,21 @@ pub fn group_spans_by_resource_and_scope(
185191

186192
#[cfg(test)]
187193
mod tests {
188-
use crate::proto::common::v1::any_value::Value;
189-
use crate::transform::common::ResourceAttributesWithSchema;
190-
use opentelemetry::trace::{
191-
SpanContext, SpanId, SpanKind, Status, TraceFlags, TraceId, TraceState,
194+
use crate::{
195+
proto::common::v1::any_value::Value, transform::common::ResourceAttributesWithSchema,
196+
};
197+
use opentelemetry::{
198+
trace::{SpanContext, SpanId, SpanKind, Status, TraceFlags, TraceId, TraceState},
199+
InstrumentationScope, KeyValue,
200+
};
201+
use opentelemetry_sdk::{
202+
resource::Resource,
203+
trace::{SpanData, SpanEvents, SpanLinks},
204+
};
205+
use std::{
206+
borrow::Cow,
207+
time::{Duration, SystemTime},
192208
};
193-
use opentelemetry::{InstrumentationScope, KeyValue};
194-
use opentelemetry_sdk::export::trace::SpanData;
195-
use opentelemetry_sdk::resource::Resource;
196-
use opentelemetry_sdk::trace::{SpanEvents, SpanLinks};
197-
use std::borrow::Cow;
198-
use std::time::{Duration, SystemTime};
199209

200210
fn create_test_span_data(instrumentation_name: &'static str) -> SpanData {
201211
let span_context = SpanContext::new(
@@ -224,7 +234,9 @@ mod tests {
224234

225235
#[test]
226236
fn test_group_spans_by_resource_and_scope_single_scope() {
227-
let resource = Resource::new(vec![KeyValue::new("resource_key", "resource_value")]);
237+
let resource = Resource::builder_empty()
238+
.with_attribute(KeyValue::new("resource_key", "resource_value"))
239+
.build();
228240
let span_data = create_test_span_data("lib1");
229241

230242
let spans = vec![span_data.clone()];
@@ -269,7 +281,9 @@ mod tests {
269281

270282
#[test]
271283
fn test_group_spans_by_resource_and_scope_multiple_scopes() {
272-
let resource = Resource::new(vec![KeyValue::new("resource_key", "resource_value")]);
284+
let resource = Resource::builder_empty()
285+
.with_attribute(KeyValue::new("resource_key", "resource_value"))
286+
.build();
273287
let span_data1 = create_test_span_data("lib1");
274288
let span_data2 = create_test_span_data("lib1");
275289
let span_data3 = create_test_span_data("lib2");

0 commit comments

Comments
 (0)