automount: fix memleak in csd-autorun

okaestne · okaestne · commit dbef7cbba5d6 · 2025-11-30T17:06:32.000+01:00
guessed_content_type also has to be freed if non-NULL (no error) but empty.
diff --git a/plugins/automount/csd-autorun.c b/plugins/automount/csd-autorun.c
@@ -798,7 +798,7 @@ autorun_guessed_content_type_callback (GObject *source_object,
 				       gpointer user_data)
 {
 	GError *error;
-	char **guessed_content_type;
+	g_auto(GStrv) guessed_content_type = NULL;
 	AutorunData *data = user_data;
 	gboolean open_folder;
 
@@ -822,7 +822,6 @@ autorun_guessed_content_type_callback (GObject *source_object,
 					open_folder = TRUE;
 				}
 			}
-			g_strfreev (guessed_content_type);
 		} else {
 			if (g_settings_get_boolean (data->settings, "automount-open")) {
 				open_folder = TRUE;

Original file line number	Diff line number	Diff line change
`@@ -798,7 +798,7 @@ autorun_guessed_content_type_callback (GObject *source_object,`
`798`	`798`	`gpointer user_data)`
`799`	`799`	`{`
`800`	`800`	`GError *error;`
`801`		`- char **guessed_content_type;`
	`801`	`+ g_auto(GStrv) guessed_content_type = NULL;`
`802`	`802`	`AutorunData *data = user_data;`
`803`	`803`	`gboolean open_folder;`
`804`	`804`
`@@ -822,7 +822,6 @@ autorun_guessed_content_type_callback (GObject *source_object,`
`822`	`822`	`open_folder = TRUE;`
`823`	`823`	`}`
`824`	`824`	`}`
`825`		`- g_strfreev (guessed_content_type);`
`826`	`825`	`} else {`
`827`	`826`	`if (g_settings_get_boolean (data->settings, "automount-open")) {`
`828`	`827`	`open_folder = TRUE;`