refactor: reuse PrintFormattedError helper for consistent error logging

Signed-off-by: ritoban23 <[email protected]>

Author: ritoban23

pkg/cmd/describe/probe.go

@@ -79,18 +79,18 @@ var probeCmd = &cobra.Command{
 				Label: "Please select the probe mode ?",
 				Items: []string{"SOT", "EOT", "Edge", "Continuous", "OnChaos"},
 			}
-			_, option, err := prompt.Run()
-			if err != nil {
-				fmt.Printf("Prompt failed %v\n", err)
-				return
-			}
+				_, option, err := prompt.Run()
+				if err != nil {
+					utils.PrintFormattedError("Prompt failed", err)
+					return
+				}
 			probeMode = option
 			fmt.Printf("You chose %q\n", option)
 		}
 		getProbeYAMLRequest.Mode = model.Mode(probeMode)
 		getProbeYAML, err := apis.GetProbeYAMLRequest(pid, getProbeYAMLRequest, credentials)
 		if err != nil {
-			utils.Red.Println(err)
+			utils.PrintFormattedError("Failed to fetch probe YAML", err)
 			os.Exit(1)
 		}
 		getProbeYAMLData := getProbeYAML.Data.GetProbeYAML
@@ -104,7 +104,7 @@ var probeCmd = &cobra.Command{
 			var prettyJSON bytes.Buffer
 			err = json.Indent(&prettyJSON, jsonData, "", "    ")
 			if err != nil {
-				utils.Red.Println("❌ Error formatting JSON: " + err.Error())
+				utils.PrintFormattedError("Error formatting JSON", err)
 				os.Exit(1)
 			}
 

pkg/cmd/get/environments.go

@@ -90,7 +90,7 @@ var GetChaosEnvironmentsCmd = &cobra.Command{
 				for _, environment := range environmentListData[start:end] {
 					intTime, err := strconv.ParseInt(environment.CreatedAt, 10, 64)
 					if err != nil {
-						fmt.Println("Error converting CreatedAt to int64:", err)
+						utils.PrintFormattedError("Error converting CreatedAt to int64", err)
 						continue
 					}
 					humanTime := time.Unix(intTime, 0)
@@ -132,12 +132,12 @@ var GetChaosEnvironmentsCmd = &cobra.Command{
 			writer.Flush()
 			intUpdateTime, err := strconv.ParseInt(environmentGetData.UpdatedAt, 10, 64)
 			if err != nil {
-				utils.Red.Println("Error converting UpdatedAt to int64:", err)
+				utils.PrintFormattedError("Error converting UpdatedAt to int64", err)
 			}
 			updatedTime := time.Unix(intUpdateTime, 0).String()
 			intCreatedTime, err := strconv.ParseInt(environmentGetData.CreatedAt, 10, 64)
 			if err != nil {
-				utils.Red.Println("Error converting CreatedAt to int64:", err)
+				utils.PrintFormattedError("Error converting CreatedAt to int64", err)
 			}
 			createdTime := time.Unix(intCreatedTime, 0).String()
 			writer.Flush()

pkg/cmd/get/probe.go

@@ -84,11 +84,11 @@ func getProbeList(projectID string, cmd *cobra.Command, credentials types.Creden
 			Label: "Do you want to enable advance filter probes?",
 			Items: []string{"Yes", "No"},
 		}
-		_, option, err := prompt.Run()
-		if err != nil {
-			fmt.Printf("Prompt failed %v\n", err)
-			return
-		}
+				_, option, err := prompt.Run()
+				if err != nil {
+					utils.PrintFormattedError("Prompt failed", err)
+					return
+				}
 		fmt.Printf("You chose %q\n", option)
 
 		if option == "Yes" {
@@ -106,7 +106,7 @@ func getProbeList(projectID string, cmd *cobra.Command, credentials types.Creden
 
 				selectedIndex, result, err := prompt.Run()
 				if err != nil {
-					fmt.Printf("Prompt failed %v\n", err)
+					utils.PrintFormattedError("Prompt failed", err)
 					os.Exit(1)
 				}
 
@@ -153,12 +153,12 @@ func getProbeList(projectID string, cmd *cobra.Command, credentials types.Creden
 		if end > totalProbes {
 			end = totalProbes
 		}
-		for _, probe := range probes_data[start:end] {
-			intTime, err := strconv.ParseInt(probe.CreatedAt, 10, 64)
-			if err != nil {
-				fmt.Println("Error converting CreatedAt to int64:", err)
-				continue
-			}
+            for _, probe := range probes_data[start:end] {
+            	intTime, err := strconv.ParseInt(probe.CreatedAt, 10, 64)
+            	if err != nil {
+            		utils.PrintFormattedError("Error converting CreatedAt to int64", err)
+            		continue
+            	}
 			humanTime := time.Unix(intTime, 0)
 			var probeReferencedBy int
 			if probe.ReferencedBy != nil {
@@ -201,12 +201,12 @@ func getProbeDetails(projectID, ProbeID string, credentials types.Credentials) {
 	writer := tabwriter.NewWriter(os.Stdout, 30, 8, 2, '\t', tabwriter.AlignRight)
 	intUpdateTime, err := strconv.ParseInt(probeGetData.UpdatedAt, 10, 64)
 	if err != nil {
-		utils.Red.Println("Error converting UpdatedAt to int64:", err)
+		utils.PrintFormattedError("Error converting UpdatedAt to int64", err)
 	}
 	updatedTime := time.Unix(intUpdateTime, 0).String()
 	intCreatedTime, err := strconv.ParseInt(probeGetData.CreatedAt, 10, 64)
 	if err != nil {
-		utils.Red.Println("Error converting CreatedAt to int64:", err)
+		utils.PrintFormattedError("Error converting CreatedAt to int64", err)
 	}
 	createdTime := time.Unix(intCreatedTime, 0).String()
 	utils.White_B.Fprintln(writer, "PROBE DETAILS")

pkg/cmd/update/password.go

@@ -99,7 +99,7 @@ var PasswordCmd = &cobra.Command{
 		} else {
 			err := errors.New("Unmatched status code: " + string(bodyBytes))
 			if err != nil {
-				utils.Red.Println("\nError updating password: ", err)
+				utils.PrintFormattedError("Error updating password", err)
 				os.Exit(1)
 			}
 		}

pkg/infra_ops/ops.go

@@ -269,7 +269,7 @@ func ValidateSAPermissions(namespace string, mode string, kubeconfig *string) {
 	for i, resource := range resources {
 		pems[i], err = k8s.CheckSAPermissions(k8s.CheckSAPermissionsParams{Verb: "create", Resource: resource, Print: true, Namespace: namespace}, kubeconfig)
 		if err != nil {
-			utils.Red.Println(err)
+			utils.PrintFormattedError("Permission check failed", err)
 		}
 	}
 

pkg/k8s/client.go

@@ -16,6 +16,7 @@ limitations under the License.
 package k8s
 
 import (
+	"fmt"
 	"os"
 	"path/filepath"
 
@@ -34,22 +35,22 @@ func ClientSet(kubeconfig *string) (*kubernetes.Clientset, error) {
 			kcfg := filepath.Join(home, ".kube", "config")
 			kubeconfig = &kcfg
 		} else {
-			utils.Red.Println("ERROR: Clientset generation failed!")
+			utils.PrintFormattedError("Clientset generation failed", fmt.Errorf("home directory not found"))
 			os.Exit(1)
 		}
 	}
 
 	// create the config
 	config, err := clientcmd.BuildConfigFromFlags("", *kubeconfig)
 	if err != nil {
-		utils.Red.Println("ERROR: ", err.Error())
+		utils.PrintFormattedError("Failed to build kubernetes config", err)
 		os.Exit(1)
 	}
 
 	// create the clientset
 	clientset, err := kubernetes.NewForConfig(config)
 	if err != nil {
-		utils.Red.Println("ERROR: ", err.Error())
+		utils.PrintFormattedError("Failed to create kubernetes clientset", err)
 		os.Exit(1)
 	}
 	return clientset, err

pkg/utils/common.go

@@ -47,13 +47,13 @@ func Scanner() string {
 		return scanner.Text()
 	}
 	if err := scanner.Err(); err != nil {
-		fmt.Fprintln(os.Stderr, "reading standard input:", err)
+		PrintFormattedError("Error reading standard input", err)
 	}
 	return ""
 }
 func PrintError(err error) {
 	if err != nil {
-		Red.Println(err)
+		PrintFormattedError("Error", err)
 		os.Exit(1)
 	}
 }