Skip to content

[MLIR Attr] Allow LocationAttr to be used as an operation attribute #167690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
+19 −1
Merged

[MLIR Attr] Allow LocationAttr to be used as an operation attribute #167690

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58e2cd8
[MLIR Attr] Allow LocationAttr to be used as an operation attribute
timnoack Nov 12, 2025
8d5b88f
Add discardable loc attr and check for builtin source loc
timnoack Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mlir/include/mlir/IR/CommonAttrConstraints.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,12 @@ class AnyAttrOf<list<Attr> allowedAttrs, string summary = "",
}

def LocationAttr : Attr<CPred<"::llvm::isa<::mlir::LocationAttr>($_self)">,
"location attribute">;
"location attribute"> {
let storageType = [{ ::mlir::LocationAttr }];
let returnType = [{ ::mlir::Location }];
let convertFromStorage = "::mlir::Location($_self)";
let constBuilderCall = "(::mlir::LocationAttr)$0";
}

def BoolAttr : Attr<CPred<"::llvm::isa<::mlir::BoolAttr>($_self)">, "bool attribute"> {
let storageType = [{ ::mlir::BoolAttr }];
Expand Down
7 changes: 7 additions & 0 deletions mlir/test/IR/locations.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,10 @@ func.func @dialect_location() {
test.attr_with_loc("dialectLoc" loc(#test.custom_location<"foo.mlir"*32>))
return
}

// CHECK-LABEL: @location_attr
// CHECK: test.op_with_loc_attr loc("cheetos":10:20)
func.func @location_attr() {
test.op_with_loc_attr loc("cheetos":10:20)
return
}
6 changes: 6 additions & 0 deletions mlir/test/lib/Dialect/Test/TestOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,6 +1192,12 @@ def TestLocationDstNoResOp : TEST_Op<"loc_dst_no_res"> {
let results = (outs);
}

def TestLocationAttrOp : TEST_Op<"op_with_loc_attr"> {
let arguments = (ins LocationAttr:$loc_attr);
let results = (outs );
let assemblyFormat = "$loc_attr attr-dict";
}

//===----------------------------------------------------------------------===//
// Test Patterns
//===----------------------------------------------------------------------===//
Expand Down
Loading