[utils] don't warn when setting rlimit fails on Solaris

[hnrklssn]

Solaris doesn't define RLIMIT_NPROC, so this is expected to fail there. This fixes a test failure in llvm/utils/lit/tests/verbosity.py on Solaris due to this unexpected warning being included in the lit output.

[llvmbot]

@llvm/pr-subscribers-testing-tools

Author: Henrik G. Olsson (hnrklssn)

Changes

Solaris doesn't define RLIMIT_NPROC, so this is expected to fail there. This fixes a test failure in llvm/utils/lit/tests/verbosity.py on Solaris due to this unexpected warning being included in the lit output.

---

Full diff: https://github.com/llvm/llvm-project/pull/167921.diff

1 Files Affected:

• (modified) llvm/utils/lit/lit/run.py (+2-1)

diff --git a/llvm/utils/lit/lit/run.py b/llvm/utils/lit/lit/run.py
index 55de914d4d2e0..3fc4a1b9b40bd 100644
--- a/llvm/utils/lit/lit/run.py
+++ b/llvm/utils/lit/lit/run.py
@@ -137,10 +137,11 @@ def _increase_process_limit(self):
                     "Raised process limit from %d to %d" % (soft_limit, desired_limit)
                 )
         except Exception as ex:
-            # Warn, unless this is Windows, z/OS, or Cygwin in which case this is expected.
+            # Warn, unless this is Windows, z/OS, Solaris or Cygwin in which case this is expected.
             if (
                 os.name != "nt"
                 and platform.system() != "OS/390"
+                and platform.system() != "SunOS"
                 and platform.sys.platform != "cygwin"
             ):
                 self.lit_config.warning("Failed to raise process limit: %s" % ex)

[hnrklssn]

@rorth How do I verify that this actually works on Solaris?

[rorth]

You could use the Solaris systems in the Cfarm, which has both Solaris/sparcv9 and Solaris/amd systems, both with current LLVM installed.

However, I've run a fresh build locally last night, which now PASSes with your patch, so I think it's good to go.

[rorth]

LGTM. Thanks.