Skip to content

Development: Fix flaky LectureIntegrationTest #11722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2025
+8 −8
Merged

Development: Fix flaky LectureIntegrationTest #11722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/test/java/de/tum/cit/aet/artemis/lecture/LectureIntegrationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void initTestCase() throws Exception {
List<Course> courses = courseUtilService.createCoursesWithExercisesAndLectures(TEST_PREFIX, true, true, numberOfTutors);
this.course1 = this.courseRepository.findByIdWithExercisesAndExerciseDetailsAndLecturesElseThrow(courses.getFirst().getId());

var lectures = this.course1.getLectures().stream().toList();
var lectures = this.course1.getLectures().stream().sorted(Comparator.comparing(Lecture::getStartDate)).toList();
createChannelsForLectures(lectures);

lecture2.setIsTutorialLecture(true);
Expand Down Expand Up @@ -544,12 +544,12 @@ void testCreateLectureSeriesAndCorrectLectureAndChannelNames() throws Exception

request.postWithoutResponseBody("/api/lecture/courses/" + course1.getId() + "/lectures", List.of(dto1, dto2), HttpStatus.NO_CONTENT);

List<Lecture> lectures = lectureRepository.findAllByCourseId(course1.getId()).stream().sorted(Comparator.comparing(Lecture::getStartDate)).toList();
assertThat(lectures).hasSize(4);
Lecture firstLecture = lectures.getFirst();
Lecture secondLecture = lectures.get(1);
Lecture thirdLecture = lectures.get(2);
Lecture fourthLecture = lectures.get(3);
List<Lecture> lecturesAfter = lectureRepository.findAllByCourseId(course1.getId()).stream().sorted(Comparator.comparing(Lecture::getStartDate)).toList();
assertThat(lecturesAfter).hasSize(4);
Lecture firstLecture = lecturesAfter.getFirst();
Lecture secondLecture = lecturesAfter.get(1);
Lecture thirdLecture = lecturesAfter.get(2);
Lecture fourthLecture = lecturesAfter.get(3);

assertThat(firstLecture.getTitle()).isEqualTo(titleNewLecture1);
assertThat(firstLecture.getStartDate().toInstant()).isEqualTo(startNewLecture1.toInstant());
Expand All @@ -564,7 +564,7 @@ void testCreateLectureSeriesAndCorrectLectureAndChannelNames() throws Exception

Set<Channel> channels = channelRepository.findLectureChannelsByCourseId(course1.getId());

assertThat(channels.stream().map(Channel::getLecture).collect(Collectors.toSet())).containsExactlyInAnyOrderElementsOf(lectures);
assertThat(channels.stream().map(Channel::getLecture).collect(Collectors.toSet())).containsExactlyInAnyOrderElementsOf(lecturesAfter);

Map<Long, Channel> lectureIdToChannelMap = channels.stream().collect(Collectors.toMap(channel -> channel.getLecture().getId(), Function.identity()));
Channel firstLectureChannel = lectureIdToChannelMap.get(firstLecture.getId());
Expand Down
Loading