Skip to content

Commit 4d9c3dc

Browse files
committed
Update READMEs, NOTICE, and docs for ctypesgen
1 parent ed864c0 commit 4d9c3dc

File tree

6 files changed

+14
-52
lines changed

6 files changed

+14
-52
lines changed

NOTICE

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,3 @@ This product includes software developed at NVIDIA Corporation.
66

77
Bifrost includes source code from the int_fastdiv library (Copyright
88
2014 Maxim Milakov) licensed under the Apache License Version 2.0.
9-
10-
Bifrost uses the PyCLibrary library (Copyright 2010 Luke Campagnola,
11-
2015 Matthieu Dartiailh) licensed under the MIT License.

README.md

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -83,23 +83,22 @@ Install dependencies:
8383

8484
Install dependencies:
8585

86-
* [PyCLibrary fork](https://github.com/MatthieuDartiailh/pyclibrary)
87-
* Numpy
86+
* numpy
8887
* matplotlib
8988
* contextlib2
9089
* pint
91-
90+
* ctypesgen
9291

9392
```
94-
$ sudo pip install numpy matplotlib contextlib2 pint git+https://github.com/MatthieuDartiailh/pyclibrary.git@dff70337fd904a43de2bdd05dc548620160354d0
93+
$ sudo pip install numpy matplotlib contextlib2 pint git+https://github.com/davidjamesca/ctypesgen.git@3d2d9803339503d2988382aa861b47a6a4872c32
9594
```
9695

9796
### Bifrost installation
9897

9998
Edit **user.mk** to suit your system, then run:
10099

101100
$ make -j
102-
$ sudo make install
101+
$ sudo make install
103102

104103
which will install the library and headers into /usr/local/lib and
105104
/usr/local/include respectively.
@@ -108,12 +107,6 @@ You can call the following for a local Python installation:
108107

109108
$ sudo make install PYINSTALLFLAGS="--prefix=$HOME/usr/local"
110109

111-
Note that the bifrost module's use of PyCLibrary means it must have
112-
access to both the bifrost shared library and the bifrost headers at
113-
import time. The LD_LIBRARY_PATH and BIFROST_INCLUDE_PATH environment
114-
variables can be used to add search paths for these dependencies
115-
respectively.
116-
117110
### Docker container
118111

119112
Install dependencies:
@@ -157,7 +150,7 @@ Doxygen documentation can be generated by running:
157150
$ make doc
158151

159152
This documentation can then be used in a Sphinx build
160-
by running
153+
by running
161154

162155
$ make html
163156

docs/source/Common-installation-and-execution-problems.rst

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,6 @@ timeout, and some blocks are not ending themselves. Quit the program (by
1212
ctrl-\\), and make sure every block in your pipeline is reading/writing
1313
to its rings as it should.
1414

15-
ImportError: No module named pyclibrary
16-
---------------------------------------
17-
18-
You have not installed PyCLibrary, or you are using two different python
19-
installations (e.g., one installed via apt-get, and one installed from
20-
source in a local directory, or one in a virtual environment). Make sure
21-
you are using the same Python to install libraries as you are to run
22-
programs. Get PyCLibrary from
23-
`here <https://github.com/MatthieuDartiailh/pyclibrary>`__.
24-
2515
OSError: ..../lib/libbifrost.so: undefined symbol: cudaFreeHost
2616
---------------------------------------------------------------
2717

@@ -33,9 +23,9 @@ still having trouble, raise an issue.
3323
OSError: Can't find library with name libbifrost.so
3424
---------------------------------------------------
3525

36-
This means that PyCLibrary can't find your Bifrost installation.
37-
Whatever library folders it searches for Bifrost, you do not have the
38-
libbifrost.so file there. To fix this, type
26+
This means that the bifrost Python wrapper can't find your Bifrost
27+
installation. Whatever library folders it searches for Bifrost, you
28+
do not have the libbifrost.so file there. To fix this, type
3929

4030
``echo $LD_LIBRARY_PATH``
4131

@@ -47,7 +37,7 @@ problem. Perform
4737

4838
where ``/my/bifrost/installation`` is the folder where you installed the
4939
Bifrost "lib" (in config.mk, this folder is given as
50-
``INSTALL_LIB_DIR``). This should add Bifrost to the PyCLibrary search
40+
``INSTALL_LIB_DIR``). This should add Bifrost to the wrapper's search
5141
path.
5242

5343
OSError: libcudart.so.x.0: cannot open shared object file: No such file or directory

docs/source/Getting-started-guide.rst

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -37,29 +37,11 @@ as follows:
3737
3. Check pip is working with ``pip list``, which will give the versions
3838
of pip and setuptools.
3939

40-
numpy, matplotlib, contextlib2, simplejson, pint, graphviz
41-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
40+
numpy, matplotlib, contextlib2, simplejson, pint, graphviz, ctypesgen
41+
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
4242

4343
If you have already installed pip, this step should be as simple as
44-
``pip install --user numpy matplotlib contextlib2 simplejson pint graphviz``.
45-
46-
`PyCLibrary (modified) <https://github.com/MatthieuDartiailh/pyclibrary>`__
47-
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
48-
49-
PyCLibrary is a Python library that will parse C files and ease the
50-
interaction with ``ctypes``. The entire Bifrost front end is built with
51-
it. **Do not install the pip version, as it is out of date**. You need
52-
to get the source from
53-
`GitHub <https://github.com/MatthieuDartiailh/pyclibrary>`__, and
54-
install it manually:
55-
56-
1. Download PyCLibrary by running
57-
``git clone https://github.com/MatthieuDartiailh/pyclibrary``
58-
2. Enter the PyCLibrary folder that was just created, and run
59-
``python setup.py install --user``.
60-
3. Check that PyCLibrary installed correctly by running ``python``, and
61-
then trying ``import pyclibrary``. If this works, you are ready to
62-
go.
44+
``pip install --user numpy matplotlib contextlib2 simplejson pint graphviz git+https://github.com/davidjamesca/ctypesgen.git@3d2d9803339503d2988382aa861b47a6a4872c32``.
6345

6446
C++ dependencies
6547
~~~~~~~~~~~~~~~~

docs/source/How-Python-and-C---fits-together.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ Once this is recompiled, open up iPython and try this:
107107
print a
108108
109109
That is: your ``AddStuff`` function is available in python via some
110-
`pyclibrary <http://pyclibrary.readthedocs.io/en/latest/>`__ magic. You
110+
`ctypesgen <https://github.com/davidjamesca/ctypesgen>`__ magic. You
111111
can't just pass ``a`` and ``b`` by themselves, but you can send their
112112
``as_BFarray()`` output.
113113

test/benchmarks/README.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Here is a list of all current and future benchmark tests for Bifrost.
4343
#. Backend
4444
1. General ring operations
4545
#. General sequence operations
46-
#. Latency of PyCLibrary calls
46+
#. Latency of Python-wrapped calls
4747
#. :code:`compile_time.sh` - Bifrost compile time
4848
#. :code:`performance_vs_serial/` - Performance comparisons with Serial
4949
1. :code:`linear_fft_pipeline.py` - Linear repeated-FFT pipeline

0 commit comments

Comments
 (0)