-
-
Notifications
You must be signed in to change notification settings - Fork 326
feat(#10318): display previous month's targets when selected #10436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10140_previous-month-targets
Are you sure you want to change the base?
Changes from 5 commits
aa03fc3
5f28fc2
7c55635
e192bbd
d3744b1
d5af983
09421ca
ed02692
afd1fed
7bd29ea
9993e25
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -48,7 +48,20 @@ | |||||||||||||||||||||||||||||||
| <h2 *ngIf="target.translation_key">{{ target.translation_key | translate }}</h2> | ||||||||||||||||||||||||||||||||
| <h2 *ngIf="!target.translation_key">{{ target.name | translateFrom }}</h2> | ||||||||||||||||||||||||||||||||
| <p *ngIf="target.subtitle_translation_key"> | ||||||||||||||||||||||||||||||||
| {{ target.subtitle_translation_key | translate }} | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| <!-- 🔹 Show “Current month” when current filter is selected --> | ||||||||||||||||||||||||||||||||
| <ng-container *ngIf="reportingPeriodFilter === 'current'; else previousSubtitle"> | ||||||||||||||||||||||||||||||||
| {{ 'targets.this_month.subtitle' | translate }} | ||||||||||||||||||||||||||||||||
| </ng-container> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| <!-- 🔹 Show “All time” when previous month is selected --> | ||||||||||||||||||||||||||||||||
| <ng-template #previousSubtitle> | ||||||||||||||||||||||||||||||||
| {{ 'targets.all_time.subtitle' | translate }} | ||||||||||||||||||||||||||||||||
| <!-- Inline note: only show when previous period --> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| </ng-template> | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||
| <!-- 🔹 Show “Current month” when current filter is selected --> | |
| <ng-container *ngIf="reportingPeriodFilter === 'current'; else previousSubtitle"> | |
| {{ 'targets.this_month.subtitle' | translate }} | |
| </ng-container> | |
| <!-- 🔹 Show “All time” when previous month is selected --> | |
| <ng-template #previousSubtitle> | |
| {{ 'targets.all_time.subtitle' | translate }} | |
| <!-- Inline note: only show when previous period --> | |
| </ng-template> | |
| {{ target.subtitle_translation_key | translate }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the label being static, The filtering does the sorting by date but leaves the labels constant. So when you click this month or last month the labels remain constant. So we decided to change the label according to what has been chosen . Though now differently as indicated in the new PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed at the squad meeting this week, we want to go ahead and leave this html as it is for now. We are continuing to discuss what the best approach will be for the UI changes. These will be implemented in r #10439.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am changing it first think tomorrow. Just got abit engaged.
Uh oh!
There was an error while loading. Please reload this page.