-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
native: Try to look for a config file based on Raspberry Pi HAT vendor #8608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the LoRa device auto-configuration functionality by adding support for dynamic config file generation for unknown devices and improving HAT vendor detection. The changes refactor error handling from exception-based to condition-based logic while adding the ability to generate configuration filenames based on device vendor and product information.
- Added
cleanupNameForAutoconffunction to sanitize device names for config filenames - Enhanced HAT detection to capture and display vendor information alongside product names
- Replaced exception-based config lookup with conditional logic and fallback config generation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
On my RPi5 (trixie) I don't have a folder |
|
I'll be getting a hat+ in the next couple days, and can compare notes then. |
|
On a Zero 2 with trixie, I have it: Is that Pi 5 specific? |
This should make it so you can add new hats (and USB devices!) without adding entries to the
configProductsmap, only by adding a new config file with the correct name based on the programmed vendor/product.🤝 Attestations