fix: resolve BLE device discovery serialization and Redux state issues #536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix BluetoothConnectionCandidate deserialization in TypeScript The Rust backend returns BluetoothConnectionCandidate as a newtype struct, but TypeScript was casting it as plain strings. Added proper mapping to extract the string value from the struct. - Add error handling for BLE scan failures Wrapped the getAvailableBluetoothDevices call in try-catch to handle BLE scanning errors gracefully and dispatch empty device list on failure. - Add missing setAutoConnectBluetooth Redux action The action was being called in the codebase but wasn't defined in the device slice reducer. Added the reducer to properly manage autoconnect Bluetooth state.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BluetoothConnectionCandidate deserialization in TypeScript The Rust backend returns BluetoothConnectionCandidate as a newtype struct, but TypeScript was casting it as plain strings. Added proper mapping to extract the string value from the struct.
Add error handling for BLE scan failures Wrapped the getAvailableBluetoothDevices call in try-catch to handle BLE scanning errors gracefully and dispatch empty device list on failure.
Add missing setAutoConnectBluetooth Redux action The action was being called in the codebase but wasn't defined in the device slice reducer. Added the reducer to properly manage autoconnect Bluetooth state.
Should resolve #534 but I don't have a PC so unable to validate on Windows. Validation passes on MacOS.