fix: resolve TranscriptStorage dual-directory test failure (#75)

* fix: resolve TranscriptStorage dual-directory test failure

Fixed bug where TranscriptStorage would save files to production .data directory
even when initialized with a test-specific temporary directory.

Changes:
- Added test mode detection based on custom output_dir parameter
- In test mode, both output_dir and data_dir use the same directory
- In production, maintains dual-directory architecture (content vs artifacts)
- Added property setters to keep directories synchronized

This ensures tests work with temporary directories while preserving the
dual-directory architecture for production use.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

* fix: remove unnecessary return statement from test

Removed `return True` from test_cache_functionality() to eliminate pytest
warning about test functions returning non-None values. Pytest uses assertions
to determine pass/fail, not return values.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>

---------

Co-authored-by: Claude <[email protected]>

Author: robotdad

scenarios/transcribe/storage/core.py

@@ -26,21 +26,48 @@ def __init__(self, output_dir: Path | None = None):
         Args:
             output_dir: Base output directory (default: AMPLIFIER_CONTENT_DIRS/transcripts)
         """
+        # Track if we're in test mode (custom output directory provided)
+        self._test_mode = output_dir is not None
+
         if output_dir:
-            self.output_dir = output_dir
+            # Custom output directory (test scenario)
+            # Use the provided directory as base for both content and data
+            self._output_dir = output_dir
+            self._data_dir = output_dir  # In test mode, keep everything together
         else:
+            # Production scenario - use dual-directory architecture
             # Use first content directory if available, otherwise fall back to data_dir
             content_dirs = paths.get_all_content_paths()
             if content_dirs:
-                self.output_dir = content_dirs[0] / "transcripts"
+                self._output_dir = content_dirs[0] / "transcripts"
             else:
                 logger.warning("No content directories found, using .data/transcripts instead")
-                self.output_dir = paths.data_dir / "transcripts"
-        self.output_dir.mkdir(parents=True, exist_ok=True)
-
-        # Add data dir for technical artifacts (JSON, VTT, SRT)
-        self.data_dir = paths.data_dir / "transcripts"
-        self.data_dir.mkdir(parents=True, exist_ok=True)
+                self._output_dir = paths.data_dir / "transcripts"
+
+            # In production, technical artifacts go to .data directory
+            self._data_dir = paths.data_dir / "transcripts"
+            self._data_dir.mkdir(parents=True, exist_ok=True)
+
+        self._output_dir.mkdir(parents=True, exist_ok=True)
+
+    @property
+    def output_dir(self) -> Path:
+        """Get the output directory."""
+        return self._output_dir
+
+    @output_dir.setter
+    def output_dir(self, value: Path) -> None:
+        """Set the output directory. In test mode, also updates data_dir."""
+        self._output_dir = value
+        if self._test_mode:
+            # Keep data_dir synchronized with output_dir in test mode
+            self._data_dir = value
+        self._output_dir.mkdir(parents=True, exist_ok=True)
+
+    @property
+    def data_dir(self) -> Path:
+        """Get the data directory."""
+        return self._data_dir
 
     def save(
         self,

scenarios/transcribe/test_cache.py

@@ -116,7 +116,6 @@ def test_cache_functionality():
         logger.info("✓ JSON metadata includes audio info correctly")
 
         logger.info("\n✅ All cache functionality tests passed!")
-        return True
 
 
 if __name__ == "__main__":