Test if mammoth resolves rlinks. (#1451)

Author: afourney

packages/markitdown/pyproject.toml

@@ -50,7 +50,7 @@ all = [
   "azure-identity"
 ]
 pptx = ["python-pptx"]
-docx = ["mammoth", "lxml"]
+docx = ["mammoth~=1.10.0", "lxml"]
 xlsx = ["pandas", "openpyxl"]
 xls = ["pandas", "xlrd"]
 pdf = ["pdfminer.six"]

packages/markitdown/tests/test_files/rlink.docx

@@ -288,6 +288,47 @@ def test_input_as_strings() -> None:
     assert "# Test" in result.text_content
 
 
+def test_doc_rlink() -> None:
+    # Test for: CVE-2025-11849
+    markitdown = MarkItDown()
+
+    # Document with rlink
+    docx_file = os.path.join(TEST_FILES_DIR, "rlink.docx")
+
+    # Directory containing the target rlink file
+    rlink_tmp_dir = os.path.abspath(os.sep + "tmp")
+
+    # Ensure the tmp directory exists
+    if not os.path.exists(rlink_tmp_dir):
+        pytest.skip(f"Skipping rlink test; {rlink_tmp_dir} directory does not exist.")
+        return
+
+    rlink_file_path = os.path.join(rlink_tmp_dir, "test_rlink.txt")
+    rlink_content = "de658225-569e-4e3d-9ed2-cfb6abf927fc"
+    b64_prefix = (
+        "ZGU2NTgyMjUtNTY5ZS00ZTNkLTllZDItY2ZiNmFiZjk"  # base64 prefix of rlink_content
+    )
+
+    if os.path.exists(rlink_file_path):
+        with open(rlink_file_path, "r", encoding="utf-8") as f:
+            existing_content = f.read()
+            if existing_content != rlink_content:
+                raise ValueError(
+                    f"Existing {rlink_file_path} content does not match expected content."
+                )
+    else:
+        with open(rlink_file_path, "w", encoding="utf-8") as f:
+            f.write(rlink_content)
+
+    try:
+        result = markitdown.convert(docx_file, keep_data_uris=True).text_content
+        assert (
+            b64_prefix not in result
+        )  # Make sure the target file was NOT embedded in the output
+    finally:
+        os.remove(rlink_file_path)
+
+
 @pytest.mark.skipif(
     skip_remote,
     reason="do not run tests that query external urls",
@@ -301,9 +342,9 @@ def test_markitdown_remote() -> None:
         assert test_string in result.text_content
 
     # Youtube
-    result = markitdown.convert(YOUTUBE_TEST_URL)
-    for test_string in YOUTUBE_TEST_STRINGS:
-        assert test_string in result.text_content
+    # result = markitdown.convert(YOUTUBE_TEST_URL)
+    # for test_string in YOUTUBE_TEST_STRINGS:
+    #    assert test_string in result.text_content
 
 
 @pytest.mark.skipif(
@@ -452,6 +493,7 @@ def test_markitdown_llm() -> None:
         test_markitdown_remote,
         test_speech_transcription,
         test_exceptions,
+        test_doc_rlink,
         test_markitdown_exiftool,
         test_markitdown_llm_parameters,
         test_markitdown_llm,