Skip to content

Commit b789a26

Browse files
authored
Merge pull request #354 from microsoft/dev/andarno/dropUnnecessaryCode
Drop custom STJ converter that we no longer need
2 parents 22a1203 + 3118e70 commit b789a26

File tree

2 files changed

+0
-54
lines changed

2 files changed

+0
-54
lines changed

src/Microsoft.ServiceHub.Framework/JsonConverterWrapper`1.cs

Lines changed: 0 additions & 45 deletions
This file was deleted.

src/Microsoft.ServiceHub.Framework/ServiceJsonRpcDescriptor.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using System.Collections.Immutable;
55
using System.Diagnostics;
66
using System.Diagnostics.CodeAnalysis;
7-
using System.Globalization;
87
using System.IO.Pipelines;
98
using Microsoft.VisualStudio.Threading;
109
using Nerdbank.Streams;
@@ -486,12 +485,6 @@ private IJsonRpcMessageFormatter CreateSystemTextJsonFormatter()
486485
DictionaryKeyPolicy = null,
487486
PropertyNamingPolicy = STJ.JsonNamingPolicy.CamelCase,
488487
DefaultIgnoreCondition = STJ.Serialization.JsonIgnoreCondition.WhenWritingNull,
489-
Converters =
490-
{
491-
// These converters are a workaround for https://github.com/dotnet/runtime/issues/85981
492-
JsonConverterWrapper<Version>.Instance,
493-
JsonConverterWrapper<Uri>.Instance,
494-
},
495488
},
496489
};
497490
}
@@ -501,8 +494,6 @@ private IJsonRpcMessageFormatter CreateSystemTextJsonFormatter()
501494
/// </summary>
502495
public class JsonRpcConnection : RpcConnection
503496
{
504-
private const string GetOptionalInterfacesMethodName = "__jsonrpc_getOptionalInterfaces";
505-
506497
private readonly ServiceJsonRpcDescriptor? owner;
507498

508499
/// <summary>

0 commit comments

Comments
 (0)