Merge pull request #170 from johnemau/fix-wv-port

dhanvikapila · web-flow · commit 25a82200fdc0 · 2020-01-28T15:36:24.000-08:00
fix: set undefined port when advanced webview debugging
diff --git a/src/edgeChromiumDebugAdapter.ts b/src/edgeChromiumDebugAdapter.ts
@@ -41,7 +41,7 @@ export class EdgeChromiumDebugAdapter extends ChromeDebugAdapter {
 
                 if (args.useWebView === 'advanced') {
                     // Advanced scenarios should use port 0 by default since we expect the callback to inform us of the correct port
-                    if (args.port === 2015) {
+                    if (!args.port || args.port === 2015) {
                         args.port = 0;
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export class EdgeChromiumDebugAdapter extends ChromeDebugAdapter {`
`41`	`41`
`42`	`42`	`if (args.useWebView === 'advanced') {`
`43`	`43`	`// Advanced scenarios should use port 0 by default since we expect the callback to inform us of the correct port`
`44`		`- if (args.port === 2015) {`
	`44`	`+ if (!args.port \|\| args.port === 2015) {`
`45`	`45`	`args.port = 0;`
`46`	`46`	`}`
`47`	`47`