tool calls in dropdown and thinking headers (#279094)

* tool calls in dropdown and thinking headers

* remove some extra code

* remove async

* some localize changes

* address some comments

* hygiene

* model call, instead of title service

* map for titles, don't generate llm title if we only find one header summary

* store titles in the part itself

Author: justschen

src/vs/workbench/contrib/chat/browser/chat.contribution.ts

@@ -747,14 +747,14 @@ configurationRegistry.registerConfiguration({
 		},
 		'chat.agent.thinking.collapsedTools': {
 			type: 'string',
-			default: 'readOnly',
-			enum: ['none', 'all', 'readOnly'],
+			default: product.quality !== 'stable' ? 'always' : 'withThinking',
+			enum: ['off', 'withThinking', 'always'],
 			enumDescriptions: [
-				nls.localize('chat.agent.thinking.collapsedTools.none', "No tool calls are added into the collapsible thinking section."),
-				nls.localize('chat.agent.thinking.collapsedTools.all', "All tool calls are added into the collapsible thinking section."),
-				nls.localize('chat.agent.thinking.collapsedTools.readOnly', "Only read-only tool calls are added into the collapsible thinking section."),
+				nls.localize('chat.agent.thinking.collapsedTools.off', "Tool calls are shown separately, not collapsed into thinking."),
+				nls.localize('chat.agent.thinking.collapsedTools.withThinking', "Tool calls are collapsed into thinking sections when thinking is present."),
+				nls.localize('chat.agent.thinking.collapsedTools.always', "Tool calls are always collapsed, even without thinking."),
 			],
-			markdownDescription: nls.localize('chat.agent.thinking.collapsedTools', "When enabled, tool calls are added into the collapsible thinking section according to the selected mode."),
+			markdownDescription: nls.localize('chat.agent.thinking.collapsedTools', "Controls how tool calls are displayed in relation to thinking sections."),
 			tags: ['experimental'],
 		},
 		'chat.disableAIFeatures': {

src/vs/workbench/contrib/chat/browser/chatContentParts/chatCollapsibleContentPart.ts

@@ -7,18 +7,24 @@ import { $ } from '../../../../../base/browser/dom.js';
 import { ButtonWithIcon } from '../../../../../base/browser/ui/button/button.js';
 import { Codicon } from '../../../../../base/common/codicons.js';
 import { Emitter } from '../../../../../base/common/event.js';
-import { IMarkdownString } from '../../../../../base/common/htmlContent.js';
-import { Disposable, IDisposable } from '../../../../../base/common/lifecycle.js';
+import { IMarkdownString, MarkdownString } from '../../../../../base/common/htmlContent.js';
+import { Disposable, IDisposable, MutableDisposable } from '../../../../../base/common/lifecycle.js';
 import { autorun, IObservable, observableValue } from '../../../../../base/common/observable.js';
 import { localize } from '../../../../../nls.js';
 import { IChatRendererContent } from '../../common/chatViewModel.js';
 import { ChatTreeItem } from '../chat.js';
 import { IChatContentPart, IChatContentPartRenderContext } from './chatContentParts.js';
+import { renderFileWidgets } from '../chatInlineAnchorWidget.js';
+import { IChatMarkdownAnchorService } from './chatMarkdownAnchorService.js';
+import { IInstantiationService } from '../../../../../platform/instantiation/common/instantiation.js';
+import { IMarkdownRenderer } from '../../../../../platform/markdown/browser/markdownRenderer.js';
+import { IRenderedMarkdown } from '../../../../../base/browser/markdownRenderer.js';
 
 
 export abstract class ChatCollapsibleContentPart extends Disposable implements IChatContentPart {
 
 	private _domNode?: HTMLElement;
+	private readonly _renderedTitleWithWidgets = this._register(new MutableDisposable<IRenderedMarkdown>());
 
 	protected readonly _onDidChangeHeight = this._register(new Emitter<void>());
 	public readonly onDidChangeHeight = this._onDidChangeHeight.event;
@@ -114,4 +120,26 @@ export abstract class ChatCollapsibleContentPart extends Disposable implements I
 			this.updateAriaLabel(this._collapseButton.element, title, this.isExpanded());
 		}
 	}
+
+
+	// Render collapsible dropdown title with widgets
+	protected setTitleWithWidgets(content: MarkdownString, instantiationService: IInstantiationService, chatMarkdownAnchorService: IChatMarkdownAnchorService, chatContentMarkdownRenderer: IMarkdownRenderer): void {
+		if (this._store.isDisposed || !this._collapseButton) {
+			return;
+		}
+
+		const result = chatContentMarkdownRenderer.render(content);
+		result.element.classList.add('collapsible-title-content');
+
+		renderFileWidgets(result.element, instantiationService, chatMarkdownAnchorService, this._store);
+
+		const labelElement = this._collapseButton.labelElement;
+		labelElement.textContent = '';
+		labelElement.appendChild(result.element);
+
+		const textContent = result.element.textContent || '';
+		this.updateAriaLabel(this._collapseButton.element, textContent, this.isExpanded());
+
+		this._renderedTitleWithWidgets.value = result;
+	}
 }