chat - consistent aux window treatment (#278563)

Author: bpasero

src/vs/workbench/contrib/chat/browser/actions/chatActions.ts

@@ -1127,7 +1127,7 @@ export function registerChatActions() {
 				resource: ChatEditorInput.getNewEditorUri(),
 				options: {
 					pinned: true,
-					auxiliary: { compact: false }
+					auxiliary: { compact: true, bounds: { width: 800, height: 640 } }
 				}
 			}, AUX_WINDOW_GROUP);
 		}

src/vs/workbench/contrib/chat/browser/actions/chatMoveActions.ts

@@ -115,17 +115,19 @@ async function executeMoveToAction(accessor: ServicesAccessor, moveTo: MoveToNew
 	const widgetService = accessor.get(IChatWidgetService);
 	const editorService = accessor.get(IEditorService);
 
+	const auxiliary = { compact: true, bounds: { width: 800, height: 640 } };
+
 	const widget = (sessionResource ? widgetService.getWidgetBySessionResource(sessionResource) : undefined)
 		?? widgetService.lastFocusedWidget;
 	if (!widget || !widget.viewModel || widget.location !== ChatAgentLocation.Chat) {
-		await editorService.openEditor({ resource: ChatEditorInput.getNewEditorUri(), options: { pinned: true, auxiliary: { compact: true, bounds: { width: 640, height: 640 } } } }, moveTo === MoveToNewLocation.Window ? AUX_WINDOW_GROUP : ACTIVE_GROUP);
+		await editorService.openEditor({ resource: ChatEditorInput.getNewEditorUri(), options: { pinned: true, auxiliary } }, moveTo === MoveToNewLocation.Window ? AUX_WINDOW_GROUP : ACTIVE_GROUP);
 		return;
 	}
 
 	const existingWidget = widgetService.getWidgetBySessionResource(widget.viewModel.sessionResource);
 	if (!existingWidget) {
 		// Do NOT attempt to open a session that isn't already open since we cannot guarantee its state.
-		await editorService.openEditor({ resource: ChatEditorInput.getNewEditorUri(), options: { pinned: true, auxiliary: { compact: true, bounds: { width: 640, height: 640 } } } }, moveTo === MoveToNewLocation.Window ? AUX_WINDOW_GROUP : ACTIVE_GROUP);
+		await editorService.openEditor({ resource: ChatEditorInput.getNewEditorUri(), options: { pinned: true, auxiliary } }, moveTo === MoveToNewLocation.Window ? AUX_WINDOW_GROUP : ACTIVE_GROUP);
 		return;
 	}
 
@@ -135,7 +137,7 @@ async function executeMoveToAction(accessor: ServicesAccessor, moveTo: MoveToNew
 
 	await widget.clear();
 
-	const options: IChatEditorOptions = { pinned: true, viewState, auxiliary: { compact: true, bounds: { width: 640, height: 640 } } };
+	const options: IChatEditorOptions = { pinned: true, viewState, auxiliary };
 	await editorService.openEditor({ resource: resourceToOpen, options }, moveTo === MoveToNewLocation.Window ? AUX_WINDOW_GROUP : ACTIVE_GROUP);
 }
 

src/vs/workbench/contrib/chat/browser/actions/chatSessionActions.ts

@@ -192,13 +192,13 @@ export class OpenChatSessionInNewWindowAction extends Action2 {
 		} else {
 			const options: IChatEditorOptions = {
 				ignoreInView: true,
+				auxiliary: { compact: true, bounds: { width: 800, height: 640 } }
 			};
 			await editorService.openEditor({
 				resource: uri,
 				options,
 			}, AUX_WINDOW_GROUP);
 		}
-
 	}
 }