Terminal suggest - include persistent options in suggestions and improve suggestion grouping #276409
+96
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances terminal completion sorting to properly prioritize different item kinds and adds support for Fig's persistent options feature. The changes introduce a hierarchical sorting order (methods/aliases → arguments → flags/options → files/folders) and enable persistent options to be inherited by subcommands in Fig completion specs.
- Adds argument prioritization in completion sorting to place arguments before flags/options
- Includes symbolic link files and folders in the resource category for sorting
- Implements Fig persistent options support with test coverage
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts | Updates comparison function to prioritize arguments and include symbolic links in resource sorting |
| src/vs/workbench/contrib/terminalContrib/suggest/test/browser/terminalCompletionModel.test.ts | Adds tests for mixed kind sorting behavior |
| extensions/terminal-suggest/src/fig/figInterface.ts | Adds persistent options to completion suggestions |
| extensions/terminal-suggest/src/test/fig.test.ts | Adds test suite for Fig persistent options feature |
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts
Show resolved
Hide resolved
src/vs/workbench/contrib/terminalContrib/suggest/browser/terminalCompletionModel.ts
Outdated
Show resolved
Hide resolved
Tyriar
approved these changes
Nov 10, 2025
Kosta-Github
added a commit
to Kosta-Github/vscode
that referenced
this pull request
Nov 11, 2025
…nal-tooltips-markdown * 'main' of https://github.com/microsoft/vscode: (56 commits) edits: show diff for sensitive edit confirmations (microsoft#276620) Enable Back button on the Manage Accounts picker (microsoft#276622) Ignore obsolete chat content parts when loading persisted session (microsoft#276615) settings cleanup (microsoft#276602) Remove unused `args: any` parameter Terminal suggest - include persistent options in suggestions and improve suggestion grouping (microsoft#276409) fix selections not being added (microsoft#276600) Embed AI search into the existing search view message (microsoft#276586) Cleanup some eslint exemptions (microsoft#276581) fix microsoft#276579 (microsoft#276590) SCM - cleanup some more eslint rules (microsoft#276571) Bump gpu types and skip lib check for gpu typing issue Fix in smoke tests Remove `forChatSessionTypeAndId` Fix one more import detect `press any/a key` and ask if user wants to send `a` to terminal (microsoft#276554) Filter subagent and todo tools from subagent requests (microsoft#276553) Expand hover setting to allow for key modifier mode (microsoft#274001) Allow partial monacoEnvironment.getWorker/getWorkerUrl Update imports ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272352
Arguments are now grouped together instead of being mixed with flags/options:
Fixes #276406
Symlink files and folders are now grouped together with regular files and folders
Fixes #276407
Options marked with
isPersistent: trueare now shown in suggestions: