Merge pull request #34 from miki725/plain

Plain backend returning list

Author: miki725

HISTORY.rst

@@ -3,6 +3,13 @@
 History
 -------
 
+0.3.2 (2017-05-19)
+~~~~~~~~~~~~~~~~~~
+
+* Fixed plain backend to return list in Python 3 vs ``filter()`` generator
+  which is not compatible with Django pagination since it requires ``len()``
+  to be implemented.
+
 0.3.1 (2017-05-18)
 ~~~~~~~~~~~~~~~~~~
 

tests/backends/test_plain.py

@@ -82,7 +82,7 @@ def _test_filter(self, spec, expected):
         backend = PlainFilterBackend(DATA)
         backend.bind([spec])
 
-        assert list(backend.filter()) == expected
+        assert backend.filter() == expected
 
     def test_filter_contains(self):
         self._test_filter(

url_filter/__init__.py

@@ -4,4 +4,4 @@
 
 __author__ = 'Miroslav Shubernetskiy'
 __email__ = '[email protected]'
-__version__ = '0.3.1'
+__version__ = '0.3.2'

url_filter/backends/plain.py

@@ -66,7 +66,7 @@ def filter_by_specs(self, queryset):
         if not self.regular_specs:
             return queryset
 
-        return filter(self._filter_callable, queryset)
+        return list(filter(self._filter_callable, queryset))
 
     def _filter_callable(self, item):
         return all(self._filter_by_spec(item, spec) for spec in self.regular_specs)