fix: AsyncMilvusClient.search support EmbeddingList #3101
Merged
+184
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jac0626
requested review from
XuanYang-cn
and removed request for
tedxu and
wangting0128
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3101 +/- ##
=========================================
Coverage ? 45.74%
=========================================
Files ? 65
Lines ? 13869
Branches ? 0
=========================================
Hits ? 6344
Misses ? 7525
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jac0626
force-pushed
the
fix/async_search_embedding_list
branch
from
7536439 to
2b10f88
Compare
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
Convert EmbeddingList to flat array in search() and hybrid_search() before calling Prepare. Enhance is_legal_search_data() to recognize EmbeddingList. Add unit tests for search and hybrid_search with EmbeddingList. Signed-off-by: silas.jiang <[email protected]>
jac0626
force-pushed
the
fix/async_search_embedding_list
branch
from
2b10f88 to
c990a59
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jac0626, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
Collaborator
XuanYang-cn
removed
the
PR | need to cherry-pick to 2.x
jac0626
added a commit
to jac0626/pymilvus
that referenced
this pull request
Dec 4, 2025
Convert EmbeddingList to flat array in search() and hybrid_search() before calling Prepare(just like the sync client). Enhance is_legal_search_data() to recognize EmbeddingList. Add unit tests for search and hybrid_search with EmbeddingList. also see milvus-io#3059 Signed-off-by: silas.jiang <[email protected]> Co-authored-by: silas.jiang <[email protected]> (cherry picked from commit ddff574) Signed-off-by: silas.jiang <[email protected]>
Contributor
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 4, 2025
…) (#3130) cherry-pick #3101 Convert EmbeddingList to flat array in search() and hybrid_search() before calling Prepare(just like the sync client). Enhance is_legal_search_data() to recognize EmbeddingList. Add unit tests for search and hybrid_search with EmbeddingList. also see #3059 (cherry picked from commit ddff574) Signed-off-by: silas.jiang <[email protected]> Co-authored-by: silas.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert EmbeddingList to flat array in search() and hybrid_search() before calling Prepare(just like the sync client). Enhance is_legal_search_data() to recognize EmbeddingList.
Add unit tests for search and hybrid_search with EmbeddingList.
also see #3059