Skip to content

Commit 062dba7

Browse files
committed
add more metrics
1 parent 54179be commit 062dba7

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

trinity/explorer/explorer.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -380,6 +380,7 @@ async def _finish_explore_step(self, step: int, model_version: int) -> None:
380380
metric.update(pipeline_metrics)
381381
if statuses:
382382
metric.update(gather_metrics([status.metrics[0] for status in statuses], "rollout"))
383+
metric["rollout/finished_task_count"] = len(statuses)
383384
self.monitor.log(metric, step=step)
384385

385386
async def _finish_eval_step(self, step: Optional[int] = None, prefix: str = "eval") -> None:
@@ -392,10 +393,11 @@ async def _finish_eval_step(self, step: Optional[int] = None, prefix: str = "eva
392393
if eval_step != step:
393394
return
394395
self.pending_eval_tasks.popleft()
395-
eval_results, _ = await self.scheduler.get_results(batch_id=f"{step}/{eval_task_name}")
396+
statuses, _ = await self.scheduler.get_results(batch_id=f"{step}/{eval_task_name}")
397+
metric[f"{prefix}/{eval_task_name}/finished_task_count"] = len(statuses)
396398
metric.update(
397399
gather_metrics(
398-
[status.metrics[0] for status in eval_results], f"{prefix}/{eval_task_name}"
400+
[status.metrics[0] for status in statuses], f"{prefix}/{eval_task_name}"
399401
)
400402
)
401403
if self.eval_start_time is not None:

0 commit comments

Comments
 (0)