Skip to content

fix: custom resolver #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −6
Open

fix: custom resolver #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/core/src/plugin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ function augmentConfig(
patchHMRClient: flags.unstable_patchHMRClient,
patchInitializeCore: flags.unstable_patchInitializeCore,
},
customResolver: config.resolver.resolveRequest,
}),
},
server: {
Expand Down
26 changes: 20 additions & 6 deletions packages/core/src/plugin/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ interface CreateResolveRequestOptions {
};
options: ModuleFederationConfigNormalized;
vmManager: VirtualModuleManager;
customResolver?: CustomResolver;
}

export function createResolveRequest({
Expand All @@ -47,6 +48,7 @@ export function createResolveRequest({
hacks,
paths,
isRemote,
customResolver,
}: CreateResolveRequestOptions): CustomResolver {
const hostEntryPathRegex = getEntryPathRegex({
entry: paths.hostEntry,
Expand Down Expand Up @@ -116,7 +118,9 @@ export function createResolveRequest({
if ([paths.initHost].includes(context.originModulePath)) {
// init-host contains definition of shared modules so we need to prevent
// circular import of shared module, by allowing import shared dependencies directly
return context.resolveRequest(context, moduleName, platform);
return customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
}

// shared modules handling in remote-entry.js
Expand All @@ -127,7 +131,9 @@ export function createResolveRequest({
const sharedPath = getSharedPath(moduleName, paths.tmpDir);
return { type: 'sourceFile', filePath: sharedPath };
}
return context.resolveRequest(context, moduleName, platform);
return customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
}

// remote modules
Expand All @@ -154,15 +160,19 @@ export function createResolveRequest({

// replace getDevServer module in remote with our own implementation
if (isRemote && moduleName.endsWith('getDevServer')) {
const res = context.resolveRequest(context, moduleName, platform);
const res = customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
const from = GET_DEV_SERVER_REGEX;
const to = resolveModule('getDevServer.ts');
return replaceModule(from, to)(res);
}

// replace HMRClient module with HMRClientShim when using bundle commands
if (isUsingMFBundleCommand() && moduleName.endsWith('HMRClient')) {
const res = context.resolveRequest(context, moduleName, platform);
const res = customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
const from = HMR_CLIENT_REGEX;
const to = resolveModule('HMRClientShim.ts');
return replaceModule(from, to)(res);
Expand All @@ -175,14 +185,18 @@ export function createResolveRequest({
moduleName.endsWith('HMRClient') &&
context.originModulePath !== resolveModule('HMRClient.ts')
) {
const res = context.resolveRequest(context, moduleName, platform);
const res = customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
const from = HMR_CLIENT_REGEX;
const to = resolveModule('HMRClient.ts');
// replace HMRClient with our own
return replaceModule(from, to)(res);
}

return context.resolveRequest(context, moduleName, platform);
return customResolver
? customResolver(context, moduleName, platform)
: context.resolveRequest(context, moduleName, platform);
};
}

Expand Down