Identify route callback in log by name

[s1037989]

"Routing to a callback" is a very common log entry that can often be difficult to identify which callback, specifically when routes are like this:

$r->get('/' => sub { $self->_method(shift, @args) });

Wondering if instead we can update Mojolicious:Routes L93:

$c->helpers->log->trace('Routing to a callback for route name ' . ($c->current_route || '/'));

Are there any situations where this log entry would be triggered but where $c->current_route wouldn't be set and '/' wouldn't be correct?

[kraih]

This would definitely be a significant performance loss.

[s1037989]

Wow! I wish I understood how you can know that!! :D

Is this any better or still too significant? Can we enable such detail only in development mode or with DEBUG?

sub continue {
  my ($self, $c) = @_;

  my $match    = $c->match;
  my $stack    = $match->stack;
  my $position = $match->position;
+ my $name     = $match->endpoint->name;
  return _render($c) unless my $field = $stack->[$position];

  # Merge captures into stash
  my $stash = $c->stash;
  @{$stash->{'mojo.captures'} //= {}}{keys %$field} = values %$field;
  @$stash{keys %$field} = values %$field;

  my $continue;
  my $last = !$stack->[++$position];
- if (my $cb = $field->{cb}) { $continue = $self->_callback($c, $cb, $last) }
+ if (my $cb = $field->{cb}) { $continue = $self->_callback($c, $name, $cb, $last) }
  else                       { $continue = $self->_controller($c, $field, $last) }
  $match->position($position);
  $self->continue($c) if $last || $continue;
}
sub _callback {
- my ($self, $c, $cb, $last) = @_;
+ my ($self, $c, $name, $cb, $last) = @_;
  $c->stash->{'mojo.routed'} = 1 if $last;
- $c->helpers->log->trace('Routing to a callback');
+ $c->helpers->log->trace("Routing to a callback for route name $name");
  return _action($c->app, $c, $cb, $last);
}

[s1037989]

Ah, I see a hook can do it, is this the best way?

hook around_action => sub ($next, $c, $action, $last) {
  $c->log->trace(sprintf "Route name: %s", $c->current_route) if $last && !$c->match->stack->[-1]->{action};
  $next->();
} if app->mode eq 'development';