replace rather than mutate channelResponders array when disconnecting

Author: Roaders

main/core/responseBroker.ts

@@ -43,16 +43,15 @@ export class ResponseBroker<T extends IResponseChannels> implements IResponseBro
     }
 
     private disconnect<K extends keyof T>(channel: K, id: string): void {
-        const responders = this.responders[channel];
+        const channelResponders = this.responders[channel];
 
-        if (responders === undefined) {
+        if (channelResponders === undefined) {
             return;
         }
 
-        const responderIndex = responders.findIndex((responder) => responder.id === id);
-        responders.splice(responderIndex, 1);
+        this.responders[channel] = channelResponders.filter((responder) => responder.id !== id);
 
-        if (responders.length === 0) {
+        if (this.responders[channel].length === 0) {
             delete this.responders[channel];
         }
     }

specs/core/responseBroker.spec.ts

@@ -1,4 +1,4 @@
-import { beforeAll, describe, expect, it, vi } from 'vitest';
+import { describe, expect, it, vi } from 'vitest';
 
 import { IResponseChannels } from '../../main/contracts/contracts.js';
 import { ResponseBroker } from '../../main/core/responseBroker.js';
@@ -116,34 +116,4 @@ describe('ResponseBroker', () => {
         responder1.disconnect();
         expect(() => responder1.disconnect()).not.toThrowError();
     });
-
-    describe('Non matching', () => {
-        let id = 0;
-        beforeAll(() => {
-            vi.doMock('uuid', () => ({ v4: () => ++id }));
-        });
-
-        it('should not disconnect responders when disconnecting', async () => {
-            const instance = getInstance<MockConfig>();
-            let responder2Count = 0;
-
-            const responder1 = instance.registerResponder('rsvpChannel', () => {
-                return 'one' as const;
-            });
-
-            instance.registerResponder('rsvpChannel', () => {
-                responder2Count++;
-                return 'two' as const;
-            });
-
-            instance.collate('rsvpChannel', { data: 'bar' });
-            expect(responder2Count).toEqual(1);
-
-            responder1.disconnect();
-
-            instance.collate('rsvpChannel', { data: 'bar' });
-
-            expect(responder2Count).toEqual(2);
-        });
-    });
 });