Skip to content

Conversation

@onionsflying
Copy link
Contributor

Description

rclcpp::WallRate is preferable to rclcpp::Rate, because with rclcpp::WallRate rate.sleep() won’t stall due to backward system clock adjustments (e.g., a one-day rollback).

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 6, 2025
Copy link
Member

@EzraBrooks EzraBrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems right to me

@EzraBrooks EzraBrooks enabled auto-merge (squash) November 26, 2025 13:50
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.18%. Comparing base (b22cae3) to head (13110f8).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...c/default_capabilities/tf_publisher_capability.cpp 0.00% 1 Missing ⚠️
...nitor/src/trajectory_monitor_middleware_handle.cpp 0.00% 1 Missing ⚠️
moveit_ros/warehouse/src/broadcast.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
- Coverage   46.19%   46.18%   -0.00%     
==========================================
  Files         720      720              
  Lines       59179    59179              
  Branches     7595     7595              
==========================================
- Hits        27331    27326       -5     
- Misses      31681    31687       +6     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EzraBrooks EzraBrooks merged commit e0ec451 into moveit:main Nov 26, 2025
9 of 10 checks passed
@github-project-automation github-project-automation bot moved this to ✅ Done in MoveIt Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants